Fix all mixin conflicts

[Alexdoru]

Your GTNH Discord Username

Alexdoru

Your Pack Version

Nightly 641

Your Server

SP

Java Version

Java 8

Type of Server

Single Player

Your Expectation

no conflicts

The Reality

When we start the pack and look at the log there's plenty of mixins conflicting with each others, it would be nice to have those resolved because every mixin conflict is either a potential bug, a missing feature or two mods wanting to add the same feature and one of those should be disabled

example of such conflicts :

[18:14:33] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinMinecraft from mod archaicfix->@Redirect::getFancyGrass(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1000, already redirected by mixins.angelica.early.json:sodium.MixinMinecraft from mod angelica->@Redirect::sodium$overrideFancyGrass(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1000
[18:14:33] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.hodgepodge.early.json:minecraft.MixinMinecraft_UnfocusedFullscreen from mod hodgepodge->@Redirect::hodgepodge$fixUnfocusedFullscreen()Z with priority 1000, already redirected by mixins.archaicfix.early.json:client.core.MixinMinecraft from mod archaicfix->@Redirect::alwaysHaveDisplayActive()Z with priority 1000

Your Proposal

fix the conflicts

Final Checklist

• [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• [X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[wlhlm]

Running nightly-725, I see the following conflicts:

1.

[11:24:17] [Client thread/WARN] [mixin]: @Inject(@At("INVOKE")) Shift.BY=2 on mixins.angelica.early.json:shaders.startup.MixinAbstractTexture from mod angelica::handler$zdp000$angelica$iris$afterGenerateId exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.

• target:net.minecraft.client.renderer.texture.AbstractTexture (injecting call in #getGlTextureId)
• conflicting mixin: Angelica
  • not a conflict, but use of brittle shift parameter in Invoke which is discouraged:

    /**
    * Get the maximum allowed value of {@link At#by}. High values of shift can
    * indicate very brittle injectors and in general should be replaced with
    * slices. This value determines the warning/error threshold (behaviour
    * determined by the environment) for the value of <tt>by</tt>.
    * 
    * @return defined shift warning threshold for this config
    */
    public int getMaxShiftByValue() {}

  • looks like this mixin was imported from iris according to its name

2.

[11:24:13] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.hodgepodge.early.json:minecraft.MixinMinecraft_UnfocusedFullscreen from mod hodgepodge->@Redirect::hodgepodge$fixUnfocusedFullscreen()Z with priority 1000, already redirected by mixins.archaicfix.early.json:client.core.MixinMinecraft from mod archaicfix->@Redirect::alwaysHaveDisplayActive()Z with priority 1000

• target: net.minecraft.client.Minecraft (patching call in #runGameLoop to org.lwjgl.opengl.Display#isActive)
• conflicting mixins: ArchaicFix, Hodgepodge
  • both implementations are identical
  • hodgepodge mixin can be disabled via config, ArchaicFix seemingly not

3.

11:24:14] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.hodgepodge.early.json:minecraft.MixinWorldUpdateEntities from mod hodgepodge->@Redirect::fasterRemoveAll(Ljava/util/List;Ljava/util/Collection;)Z with priority 1000, already redirected by mixins.archaicfix.early.json:common.core.MixinWorld from mod archaicfix->@Redirect::removeInUnloaded(Ljava/util/List;Ljava/util/Collection;)Z with priority 1000

• target: net.minecraft.world.World (patching call in #updateEntities to java.util.List#removeAll)
• conflicting mixins: ArchaicFix, Hodgepodge
  • both implementations are identical
  • hodgepodge mixin can be disabled via config, ArchaicFix can also be disabled via config

4.

[11:24:14] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.bugtorch.early.json:minecraft.fastrandom.MixinWorldClient from mod bugtorch->@Redirect::redirectDoVoidFogParticlesRandom()Ljava/util/Random; with priority 1000, already redirected by mixins.angelica.early.json:notfine.particles.MixinWorldClient from mod angelica->@Redirect::notFine$redirectDoVoidFogParticlesRandom()Ljava/util/Random; with priority 1000

• target: net.minecraft.world.World (patching call in #updateEntities to java.util.List#removeAll)
• conflicting mixins: BugTorch, Angelica
  • both implementations are identical
  • the Angelica implementation was imported from notfine which has the same author as BugTorch

5.

[11:24:17] [Client thread/WARN] [mixin]: Method overwrite conflict for func_77018_a in mixins.bugtorch.early.json:minecraft.rendering.MixinRenderItem from mod bugtorch, previously written by com.gtnewhorizons.angelica.mixins.early.notfine.fix.MixinRenderItem. Skipping method.

• target: net.minecraft.client.renderer.entity.RenderItem (replacing #renderGlint, aka func_77018_a)
• conflicting mixins: BugTorch, Angelica
  • both implementations are identical
  • the Angelica implementation was imported from notfine which has the same author as BugTorch

6.

[11:24:17] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.bugtorch.early.json:minecraft.rendering.MixinEffectRenderer from mod bugtorch->@Redirect::skipGlDepthMask(Z)V with priority 1000, already redirected by mixins.angelica.early.json:notfine.particles.MixinEffectRenderer from mod angelica->@Redirect::skipGlDepthMask(Z)V with priority 1000

• target: net.minecraft.client.particle.EffectRenderer (patching #renderParticles to make call to org.lwjgl.opengl.GL11#glDepthMask do nothing)
• conflicting mixins: BugTorch, Angelica
  • both implementations are identical
  • the Angelica implementation was imported from notfine which has the same author as BugTorch

7.

[11:24:13] [main/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinMinecraft from mod archaicfix->@Redirect::getFancyGrass(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1000, already redirected by mixins.angelica.early.json:sodium.MixinMinecraft from mod angelica->@Redirect::sodium$overrideFancyGrass(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1000

• target: net.minecraft.client.Minecraft (patching field access in #runGameLoop to modify fancy grass graphics setting)
• conflicting mixins: ArchaicFix, Angelica
  • ArchaicFix always forces fancy grass rendering
  • Angelica mixin allows configuring fancy grass setting
  • Angelica implementation should be prioritized/replace ArchaicFix implementation

8.

[11:24:17] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinRenderItem from mod archaicfix->@Redirect::forceFancyGraphics(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1000, already redirected by mixins.angelica.early.json:notfine.toggle.MixinRenderItem from mod angelica->@Redirect::notFine$toggleDroppedItemDetail(Lnet/minecraft/client/settings/GameSettings;)Z with priority 1100

• target: net.minecraft.client.renderer.entity.RenderItem (patching field access in #renderDroppedItem to force fancy graphics setting)
• conflicting mixins: ArchaicFix, Angelica
  • implementations are pretty similar
  • mixin allows setting fancy graphics rendering in this location according to either of their configs
  • Angelica should take precedence here
  • already done as the Angelica mixin sets a higher priority (1100 as opposed to the default 1000), so warning can probably be ignored

9.

[11:24:25] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinThreadDownloadImageData from mod archaicfix->@Redirect::onThreadStart(Ljava/lang/Thread;)V with priority 1000, already redirected by mixins.angelica.early.json:angelica.archaic.MixinThreadDownloadImageData from mod angelica->@Redirect::onThreadStart(Ljava/lang/Thread;)V with priority 1000

• target: net.minecraft.client.Minecraft (patching field access in #runGameLoop to modify fancy grass graphics setting)
• conflicting mixins: ArchaicFix, Angelica
  • both implementations are identical
  • seems like parts of ArchaicFix are integrated into Angelica

10.

[11:24:28] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:common.core.MixinChunkProviderServer from mod archaicfix->@Redirect::populateChunkWithBiomes(Lnet/minecraft/world/chunk/IChunkProvider;II)Lnet/minecraft/world/chunk/Chunk; with priority 1000, already redirected by mixins.angelica.early.json:sodium.MixinChunkProviderServer from mod angelica->@Redirect::sodium$populateChunkWithBiomes(Lnet/minecraft/world/chunk/IChunkProvider;II)Lnet/minecraft/world/chunk/Chunk; with priority 1000

• target: net.minecraft.world.gen.ChunkProviderServer (modify chunk loading in #originalLoadChunk)
• conflicting mixins: ArchaicFix, Angelica
  • both implementations are identical
  • seems like parts of ArchaicFix are integrated into Angelica

11.

[11:24:31] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinNetHandlerPlayClient from mod archaicfix->@Redirect::onGuiDisplayJoin(Lnet/minecraft/client/Minecraft;Lnet/minecraft/client/gui/GuiScreen;)V with priority 500, already redirected by mixins.angelica.early.json:angelica.archaic.MixinNetHandlerPlayClient from mod angelica->@Redirect::onGuiDisplayJoin(Lnet/minecraft/client/Minecraft;Lnet/minecraft/client/gui/GuiScreen;)V with priority 500
[11:24:31] [Client thread/WARN] [mixin]: @Redirect conflict. Skipping mixins.archaicfix.early.json:client.core.MixinNetHandlerPlayClient from mod archaicfix->@Redirect::onGuiDisplayRespawn(Lnet/minecraft/client/Minecraft;Lnet/minecraft/client/gui/GuiScreen;)V with priority 500, already redirected by mixins.angelica.early.json:angelica.archaic.MixinNetHandlerPlayClient from mod angelica->@Redirect::onGuiDisplayRespawn(Lnet/minecraft/client/Minecraft;Lnet/minecraft/client/gui/GuiScreen;)V with priority 500

• target: net.minecraft.client.network.NetHandlerPlayClient (patch call to net.minecraft/client.Minecraft.displayGuiScreen() in #handleJoinGame, and #handleRespawn)
• conflicting mixins: ArchaicFix, Angelica
  • both implementations are identical
  • seems like parts of ArchaicFix are integrated into Angelica

[wlhlm]

No. 1 could be refactored to not use Shift.BY, I guess.

No. 4 to no. 11 are conflicts involving Angelica: I'm not entirely sure what the plan is here, but it seems like Angelica includes parts (all?) of ArachaicFix and BugTorch (by way of notfine), so I'm guessing those will eventually be removed from the pack? That fix would those mixin conflicts. @mitchej123 can you explain?

No. 2, and no. 3 are conflicts between hodgepodge and ArchaicFix. If my guess in the previous paragraph is correct, that we'll eventually drop ArchaicFix then that'll get rid of the conflict.

[Alexdoru]

Most of the mixin conflicts come from mods that both have the same feature implemented, we need to edit the mods to delete the feature in one of the mods