GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
952 stars 296 forks source link

orevein names in nei are broken #17404

Closed chochem closed 20 hours ago

chochem commented 21 hours ago

Your GTNH Discord Username

chochem

Your Pack Version

2.7.0 beta1

Your Server

SP

Java Version

Java 21

Type of Server

None

Your Expectation

the localisation worked before (just default english here)

The Reality

image

Your Proposal

fix it :)

Final Checklist

chochem commented 21 hours ago

the lang file still seems to be there. I am not sure whats going on.

https://github.com/chochem/VisualProspecting/blob/master/src/main/resources/assets/gregtech/lang/en_US.lang I am an idiot looking on a outdated fork. oops

https://github.com/GTNewHorizons/GT5-Unofficial/blob/7838937a6df4513ac5829f3b81554f51fae9c64a/src/main/java/gtneioreplugin/plugin/gregtech5/PluginGT5VeinStat.java#L96

Lyfts commented 21 hours ago

Wtf https://github.com/GTNewHorizons/GT5-Unofficial/blob/7838937a6df4513ac5829f3b81554f51fae9c64a/src/main/java/gtneioreplugin/plugin/gregtech5/PluginGT5VeinStat.java#L95-L97, it was using VP to translate it and that was removed recently. That should either be localized in GT5U or it should use something else entirely.

boubou19 commented 21 hours ago

ah i love random intermod hard deps to do trivial stuff...

chochem commented 21 hours ago

its not a hard dep. its has vpmodloaded check and a backup alternative. but of course vp is still loaded, the lang file was just nuked.