Torch on the head - Githubissues

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery

https://www.gtnewhorizons.com/

Other

968 stars 298 forks source link

Torch on the head #17444

Open MaGeBZz opened 1 week ago

MaGeBZz commented 1 week ago

Your GTNH Discord Username

marvinhhmagebzz

Your Pack Version

2.7 Beta 1

Your Server

Java Version

Java 17

Type of Server

Single Player

Your Expectation

That shouldn't happen I guess lol

The Reality

You can place a torch on your head in the tab (look screenshot) and it will still emit light even if it's there

Your Proposal

Fix that the torch can't be on the head slot haha

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

NotAPenguin0 commented 1 week ago

You can place any block there, not sure how intentional this is but honestly I'd classify this as not a bug or if anything a very harmless bug.

leumasme commented 1 week ago

The having blocks on your head part is intended by some mod as a cosmetic thing, pretty sure (should be visible on player). Having all visible slots of the player activate dynamic lights is expected/makes sense and is pretty neat. Maybe for blocks that won't properly be rendered on head like torches (what's going on there lol, it's floating around behind the player?) it could be changed, but ex. for blocks that should(?) render fine glowstone block this seems fine imo.

NotAPenguin0 commented 1 week ago

Agree, I think this isn't really a bug

chochem commented 1 week ago

this really sounds like a bug, weird. what mod 'intends' stuff like that?

MaGeBZz commented 1 week ago

@chochem would say so too I mean it's not a huge bug or so but still it's weird although it's a good alternative cause you don't have a real off-hand like in newer minecraft versions to hold a torch the whole time in it while mine things for example

leumasme commented 1 week ago

I don't know which mod adds it but placing blocks on your head is a common feature even on modern servers (/head command), since the game already has functionality to render a block on the player head slot so many just let the player use it as a cosmetic thing; so I assume it's intended by some mod, especially since it's only the head slot (right?). If there's intent to remove it then maybe we could think about getting some type of earlygame-ish helmet that emits dynamic light? I think it's really neat.

MaGeBZz commented 1 week ago

@leumasme yeah I guess it's just a bit weird with the torch but if it's on me it doesn't have to be fixed but wanna mention it at least and maybe getting discussed But yeah only head slot But yeah with dynamic lights now (from angelica I guess?) I think a helmet with dynamic light like this bug would be really neat Maybe something like torch + leather strap kinda (really just a small idea rn lol)

chochem commented 5 days ago

ok I tried and this doesnt actually seem to be a thing. no torch in head slot.

chochem commented 5 days ago

ok so it only works when you put it on in a strange way and the rendering is all wrong. there are certainly bugs here. even if its a botched feature underneath.

Caedis commented 5 days ago

The dynamic lights working with it is intended since I liked the "feature" from OF