GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.02k stars 315 forks source link

Distillation Towers Do Not Recognize Space in ME Hatches for void protection #17711

Open Ruling-0 opened 1 month ago

Ruling-0 commented 1 month ago

Your GTNH Discord Username

ruling_

Your Pack Version

Nightly 695

Your Server

Private Server

Java Version

Java 21

Type of Server

None

Your Expectation

The Distillation Tower / Dangote / Mega DT should recognize it has enough space in an ME output hatch to run a recipe and then run the recipe.

The Reality

If the DT is built using ME output hatches, even if they are large enough, it will refuse to run unless set to void overflow (it doesn't void anything, it does correctly place in the output). It works fine with normal output hatches.

Your Proposal

ME Output hatches should work.

Final Checklist

pilchard436 commented 3 weeks ago

this only occurs when you mix me output hatch with normal output hatch.

Yoshy2002 commented 3 weeks ago

Same Bug in Nightly 719. DT for Distilled Water with Me Output Hatch at 2nd Layer and Normal UHV(doesnt matter how big) Output Hatch at 3rd layer wont work, even tho the Output is only affecting the Second Layer with the ME Output Hatch. (To reproduce)

Ruling-0 commented 3 hours ago

image image

Appears the fix has broken things further - this DTPF is producing the eternal coil hypogen recipe. After update it shut down, and only runs if void protection is on. A key thing to note is that the spacetime DTPF runs fine, leading me to believe it's an issue for recipes that output multiple fluids.

On talking on the Discord, it appears it requires 1 ME hatch per fluid in the output to function. https://discord.com/channels/181078474394566657/181078474394566657/1312961226111713320

All tested on RC2.

Reopening and flagging critical because this will now certainly break many existing setups.

Ruling-0 commented 2 hours ago

I also think even when it would run with void protection on, void protection just wasn't working. I watched it keep running a recipe and eating all the ingredients while having no output space.

LCR subticking Phthalic, the 33ML hatch was full, it had 4 128kL hatches available, and just kept running the recipe while the 128kL did not fill.

This is also present in RC1 and just occurs if a machine has multiple ME output hatches, which probably no one has ever done before so was undocumented. Unrelated to this issue or the fix.