GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.02k stars 311 forks source link

Falling block damage can destroy electric goggles #17849

Open leumasme opened 3 weeks ago

leumasme commented 3 weeks ago

Your GTNH Discord Username

leumasme

Your Pack Version

2.6.1

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

Electric Goggles of Revealing should not be breakable, their durability just works as battery charge.

The Reality

Electric Goggles of Revealing can be destroyed by falling block damage. This type of damage can be caused by, for example, anvils or falling obsidian (HEE).

https://github.com/user-attachments/assets/7daa2ec4-7239-4e56-98f2-4d8f4443d799

Falling block damage will damage helmet durability more, this is a vanilla mechanic. This doesn't seem to apply to the electric goggles, they always take just one damage. I suspect If the durability damage from the Falling Block damage would be enough to immediately destroy the electric goggles, they are destroyed. This means that this can also happen with a very low-damage falling obsidian block during the dragon fight, if the goggles are (nearly) empty, since their durability % is generally synced with their charge %.

This applies to all types of electric goggles, and likely also other charge-based headgear:

Your Proposal

Fix this edgecase

Final Checklist

chochem commented 2 weeks ago

the video file says its corrupt and can not be played. at least for me.

wlhlm commented 2 weeks ago

Works in a video player (right click -> save as), just not embedded in the browser.

leumasme commented 2 weeks ago

Maybe your browser doesn't support H.265 for some reason, works fine here (chrome on windows). Shown in the video is player wearing "Electric Goggles of Revealing", then executing the command /summon ~ ~20 ~ anvil to summon a falling anvil 20 blocks above the player. When the anvil hits the player, the goggles are broken

Ruling-0 commented 2 weeks ago

Reproduced as video (give goggles, use heart canisters for HP, drop anvil from 20 with /setblock ~ ~20 ~ anvil) on Nightly 727