GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.02k stars 311 forks source link

findIt crash when searching nearby containers for thaumcraft knowledge fragments ("stackAspects" is null) #18017

Closed Flakxo closed 6 days ago

Flakxo commented 1 week ago

Your GTNH Discord Username

.flaxo

Your Pack Version

2.7.0-nightly-2024-11-11

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Actions

Using findIt to try and locate knowledge fragments from thaumcraft in nearby containers causes a crash to menu screen

Crash Report

https://mclo.gs/NqsBdB9

Final Checklist

github-actions[bot] commented 1 week ago

Found 1 linked crash report(s)

Primitive Automated Analysis of Crash Report

https://mclo.gs/NqsBdB9

Stacktrace
java.lang.NullPointerException: Cannot invoke "thaumcraft.api.aspects.AspectList.size()" because "stackAspects" is null
  at com.gtnh.findit.handler.ThaumcraftProvider$AspectStackFilter.matches(ThaumcraftProvider.java:35)
  at com.gtnh.findit.service.itemfinder.FindItemRequest.isStackSatisfies(FindItemRequest.java:75)
  at com.gtnh.findit.service.itemfinder.ClientItemFindService$TickListener.onClientPostTick(ClientItemFindService.java:132)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler_804_TickListener_onClientPostTick_ClientTickEvent.invoke(.dynamic)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
  at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
  at cpw.mods.fml.common.FMLCommonHandler.onPostClientTick(FMLCommonHandler.java:330)
  at net.minecraft.client.Minecraft.runTick(Minecraft.java:2064)
  at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:973)
  at net.minecraft.client.Minecraft.run(Minecraft.java:6110)
  at net.minecraft.client.main.Main.main(SourceFile:148)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at net.minecraft.launchwrapper.Launch.rfb$realLaunch(Launch.java:250)
  at net.minecraft.launchwrapper.Launch.launch(Launch.java:35)
  at net.minecraft.launchwrapper.Launch.main(Launch.java:60)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at com.gtnewhorizons.retrofuturabootstrap.Main.main(Main.java:207)
  at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
  at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
  at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Alexdoru commented 1 week ago

this is fixed already you can download the updated version of the mod here https://github.com/GTNewHorizons/FindIt/releases

wlhlm commented 6 days ago

The crashlog above shows a different NPE. This will hopefully be fixed by https://github.com/GTNewHorizons/FindIt/pull/26