FindIt + Thaumcraft still crashing when aspect containing items are in a container

[truenachtara]

Your GTNH Discord Username

No response

Your Pack Version

2.7.0-beta4

Your Server

Private server

Java Version

Java 21

Type of Server

None

Your Actions

Search for enchanted fabric in a chest Then the next chest I open contains phials of essentia (while findit is still "hot")

This also works with crystallized essentia, mana beans, and ethereal essence,

Crash Report

https://mclo.gs/iC6HYLN https://mclo.gs/JJbNmzJ

Final Checklist

• [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the crash still exists will prompt us to investigate and reopen it once we confirm your report.
• [X] I can reproduce this crash consistently by following the exact steps I described above.
• [X] I have asked other people and they confirm they also crash by following the exact steps I described above.

[github-actions[bot]]

Found 2 linked crash report(s)

Primitive Automated Analysis of Crash Report

https://mclo.gs/iC6HYLN

Stacktrace

java.lang.NullPointerException: Cannot invoke "thaumcraft.api.aspects.AspectList.size()" because "stackAspects" is null
  at com.gtnh.findit.handler.ThaumcraftProvider$AspectStackFilter.matches(ThaumcraftProvider.java:35)
  at com.gtnh.findit.service.itemfinder.FindItemRequest.isStackSatisfies(FindItemRequest.java:75)
  at com.gtnh.findit.service.itemfinder.ClientItemFindService$TickListener.onClientPostTick(ClientItemFindService.java:132)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler_810_TickListener_onClientPostTick_ClientTickEvent.invoke(.dynamic)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
  at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
  at cpw.mods.fml.common.FMLCommonHandler.onPostClientTick(FMLCommonHandler.java:330)
  at net.minecraft.client.Minecraft.runTick(Minecraft.java:2064)
  at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:973)
  at net.minecraft.client.Minecraft.run(Minecraft.java:6110)
  at net.minecraft.client.main.Main.main(SourceFile:148)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at net.minecraft.launchwrapper.Launch.rfb$realLaunch(Launch.java:250)
  at net.minecraft.launchwrapper.Launch.launch(Launch.java:35)
  at net.minecraft.launchwrapper.Launch.main(Launch.java:60)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.gtnewhorizons.retrofuturabootstrap.Main.main(Main.java:219)
  at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
  at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
  at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

Primitive Automated Analysis of Crash Report

https://mclo.gs/JJbNmzJ

Stacktrace

java.lang.NullPointerException: Cannot invoke "thaumcraft.api.aspects.AspectList.size()" because "stackAspects" is null
  at com.gtnh.findit.handler.ThaumcraftProvider$AspectStackFilter.matches(ThaumcraftProvider.java:35)
  at com.gtnh.findit.service.itemfinder.FindItemRequest.isStackSatisfies(FindItemRequest.java:75)
  at com.gtnh.findit.service.itemfinder.ClientItemFindService$TickListener.onClientPostTick(ClientItemFindService.java:132)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler_810_TickListener_onClientPostTick_ClientTickEvent.invoke(.dynamic)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
  at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
  at cpw.mods.fml.common.FMLCommonHandler.onPostClientTick(FMLCommonHandler.java:330)
  at net.minecraft.client.Minecraft.runTick(Minecraft.java:2064)
  at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:973)
  at net.minecraft.client.Minecraft.run(Minecraft.java:6110)
  at net.minecraft.client.main.Main.main(SourceFile:148)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at net.minecraft.launchwrapper.Launch.rfb$realLaunch(Launch.java:250)
  at net.minecraft.launchwrapper.Launch.launch(Launch.java:35)
  at net.minecraft.launchwrapper.Launch.main(Launch.java:60)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.gtnewhorizons.retrofuturabootstrap.Main.main(Main.java:219)
  at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
  at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
  at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

[wlhlm]

I have a potential fix for this, but wasn't able to reproduce the crash. Can you please confirm if the problem goes away with the following build: https://github.com/GTNewHorizons/FindIt/suites/31077234850/artifacts/2208477534

If it still crashes, please post the crashlog.

I can reproduce now. Should be fixed with the PR.