GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.02k stars 310 forks source link

Space Elevator Space Pump overflows me output hatch with big batch sizes #18053

Open StaffiX opened 1 day ago

StaffiX commented 1 day ago

Your GTNH Discord Username

StaffiX

Your Pack Version

Nightly 730

Your Server

Single Player

Java Version

Java 21

Type of Server

Single Player

Your Expectation

ME output hatch should not display negative fluid values, and void fluids as a result

The Reality

When you set batch size to a number that would max int overflow the space pump (usually with a later tier pump, such as Mk3), it overflows the me output hatch, due to the hatch not being able to accept more than max int at a time.

image

https://discord.com/channels/181078474394566657/181078474394566657/1209995090941055006

Your Proposal

Space pump should have a special handling for this

Final Checklist

Eranicus commented 1 day ago

negatives are new thing, maybe after changes to ME output hatches?

Just tested on 2.6.1 MK3 x4 hydrogen

Batch size 20

Screenshot 2024-11-21 184759

Batch size 64

Screenshot 2024-11-21 184949

Batch size 128

Screenshot 2024-11-21 190117