search

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
1.01k stars 305 forks source link

electro magic nanosuit loses pollution protection #2541

Closed Prewf closed 6 years ago

Prewf commented 6 years ago

Which modpack version are you using?

2.0.2.7 #

If in multiplayer; On which server does this happen?

Private Server #

What did you try to do, and what did you expect to happen?

I upgraded my nanosuit boots and helmet into the electro-magic versions, Nanosuit Boots of the Traveler and Nanosuit Goggles of Revealing. #

What happend instead? (Attach screenshots if needed)

IC2 nanosuit protects against pollution effects (slowness, mining fatigue, weakness), but when I upgraded my boots and helm to electro-magic nanosuit variants, I lost that protection. #

What do you suggest instead/what changes do you propose?

I propose to keep that protection. Make it consistent with the IC2 nanosuit behavior.

TechnicianLP commented 6 years ago

The Quantum parts provided by ElectroMagicTools are not allowed for the secret Gravi-Chestplate Mode either btw.

Dream-Master commented 6 years ago

@TechnicianLP is it possible to add some code to make them protect against pollution?

TechnicianLP commented 6 years ago

Why exactly am i supposed to know if such a thing is possible? i was just pointing out a secpnd bug in that mod ...

Dream-Master commented 6 years ago

Everyone have more coding knowledge than myself so thats why i ask :P

Kortako commented 6 years ago

Here's a fix, but I'm not sure it's the best place to put it. IC2 registers its own armors in the pollution list some time in their post-init phase, but I wasn't sure if I could figure out how to make EMT do it as well (since we don't have IC2 code forked, I couldn't tell how they do it). But I've tested this code and it works.

Dream-Master commented 6 years ago

If it works all fine I guess. Ic2 code is not open source.