GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
977 stars 299 forks source link

Dirt cheap villagers #2893

Closed bashduude closed 3 years ago

bashduude commented 6 years ago

Which modpack version are you using?

2030 #

If in multiplayer; On which server does this happen?

#

What did you try to do, and what did you expect to happen?

#

What happend instead? (Attach screenshots if needed)

#

What do you suggest instead/what changes do you propose?

image

Take a look at villagers trade tables. Some of them need to be tweaked, For example 24 wood => apiary

draknyte1 commented 6 years ago

Unless you can spawn villagers, it's not abusable. At that point, it doesn't matter~

They'll only sell a few then you need to find another one.. then give him the correct wood.. rinse and repeat, rather slow based on villager rng.

Dream-Master commented 6 years ago

yea but use them a special forestry wood are better than vanilla wood planks. Will see what I can do.

draknyte1 commented 6 years ago

Pretty sure they ask for any plank type that exists.. vanilla planks count but more often then not I'm pretty sure the want forestry logs. Maybe I'm wrong but I don't see why they wouldn't use forestry planks when it's added by forestry.

richardhendricks commented 6 years ago

That's been a pretty standard trade since forever. I'd be real hesitant to change it much. They can accept any wood in my experience.

If any, I would change the trade to be more wood and also some honeycombs. Or maybe honey drops if you want players to actually work for it.

Dream-Master commented 6 years ago

idk if I can change it

draknyte1 commented 6 years ago

You can't unless you fork forestry. (Or can you Minetweak villager recipes?) I'm under the assumption we will anyway to fix butterflies, so just do it then.

Dream-Master commented 6 years ago

I fork bop now for sapling recipes but we can fork forestry aswell

0lafe commented 6 years ago

Unless you can spawn villagers, it's not abusable. At that point, it doesn't matter~

You can spawn them in more than one way

draknyte1 commented 6 years ago

Spawn eggs? They cost. Villager farm? You're still relying on slow RNG.

Only a spawner is practical to abuse this on any level called abuse.

0lafe commented 6 years ago

There are villager spawners you can craft around MV

draknyte1 commented 6 years ago

Regardless, let's say there's 10 villager types, then for each type there's 10-15 trades. That's like a 1% chance to get the correct villager, which then only sells you 3-4 apiaries. After that, you need another one.

0lafe commented 6 years ago

By MV they aren't too hard to craft anyway so it's not a big deal

draknyte1 commented 6 years ago

Basically my point is that the effort required to spawn villagers to exploit this at any decent speed is still slower than just making them. :)

bartimaeusnek commented 6 years ago

imo this should stay in as a "feature"

richardhendricks commented 6 years ago

I'd like to see more useful trades across the board for villagers. But would encourage hoarding and farming them. Which would mean more zombie sieges. So maybe a good thing! 👍

0lafe commented 6 years ago

I too am in favor of some new trades if that's possible, That could be cool

Dream-Master commented 6 years ago

look for a mod can control it @0lafe

draknyte1 commented 6 years ago

We can do it via DreamCore if you want?

Just make up a list of trades and I'll PR them in a week :)

0lafe commented 6 years ago

https://minecraft.curseforge.com/projects/custom-trades-mod/files if not this might work

draknyte1 commented 6 years ago

Why add more mods when we could do it ourselves? Allows more flexibility and new villager options too.

bartimaeusnek commented 6 years ago

yeah i agree with @draknyte1 here, also the mod @0lafe posted has this license: "This work is dedicated to the public domain." Which means we can do whatever we want to it. IMO we should merge this: https://github.com/GTNewHorizons/NewHorizons/issues/2874 and the mod from above or @draknyte1 into the coremod as fixes.

Dream-Master commented 6 years ago

sure this works too. but we need to be able to add and remove trades

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days