GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
977 stars 299 forks source link

Can no longer shape chiseled glass in the architecture table (also cannot chisel shaped glass). #3761

Closed melignus closed 5 years ago

melignus commented 5 years ago

Which modpack version are you using?

2.0.5.1 (problem first showed up several months ago, my brother can't recall what version the error showed up in) *he now recalls that it stopped working around April, but I'm not sure what version we were on. I do know until summer we were updating within days of new releases. #

If in multiplayer; On which server does this happen?

Our family server on AWS. #

What did you try to do, and what did you expect to happen?

Place chiseled glass into the Architecture table and get shaped chiseled glass out. #

What happend instead? (Attach screenshots if needed)

This no longer works. Vanilla glass still works and can be shaped. Chiseled glass cannot be shaped, and shaped glass cannot be chiseled. The roof of our factory didn't disappear, but we're unable to produce more of the chisel textured shaped glass to repair or expand. #

What do you suggest instead/what changes do you propose?

I figure that chisel is probably fine because we still have the chiseled shaped glass roofs. They didn't disappear on us. But I think maybe a block meta value changed for the chiseled glass to where the architecture table no longer detects the chiseled blocks as valid input.

melignus commented 5 years ago

I was able to fix this by patching a method in ArchitectureCraft that checks for "acceptable materials." I'm going to try and pull the hard coded values out into a config file and submit the patch to the maintainer. Then I'll reply back here with an update.

melignus commented 5 years ago

I've packaged up my patch and sent it to the mod maintainer of ArchitectureCraft for consideration. The patch changes the check in the "isAcceptableMaterial" to include a list of material names from a config file. Hopefully this change will make it easier for modpack maintainers by removing the need for recompilation to incorporate new materials or changes to material names.

Dream-Master commented 5 years ago

@melignus we have architecture table forked so far i know. Send me a pull request if you want.

Dream-Master commented 5 years ago

@melignus i need more infos and pics from the block you want to put in.

melignus commented 5 years ago

Sorry for the long delay on response. I've finally written and tested the fix for this issue and created two pull requests.

This was quite an interesting learning experience ;) Might have to take a look at some of the other open programming issues!