GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
977 stars 299 forks source link

AE2 Fluid interfaces malfunction after upgrade. #5069

Closed drayath closed 2 years ago

drayath commented 4 years ago

Which modpack version are you using?

GTNH-1.7.10-2.0.7.6e-dev.zip

#

If in multiplayer; On which server does this happen?

Private

#

What did you try to do, and what did you expect to happen?

Upgraded from 2.0.7.5 to GTNH-1.7.10-2.0.7.6e-dev.zip

All existing AE2 fluid interfaces with a fluid output set have the fluid output type replaced with some sort of bad fluid type (different color than the original fluid, tooltip shows no name, no fluid outputted)

You then need to go round you base working out all the correct fluid output type and resetting the output filter.

In addition previously when in the fluid interface ui the tooltip (on each column) showed which face of the interface the fluid would output to (north, up, west etc) this is no longer shown.

#

What happened instead? (Attach screenshots if needed)

#

What do you suggest instead/what changes do you propose?

Upgrade should not break existing setting if at all possible. Return the UI output face tooltip as it is extremely useful.

Dream-Master commented 4 years ago

So far ik Fluids have no fix id thats why it happend most of the time when a updates come. Idk if somone can help me code a fix if it is fixable.

richardhendricks commented 4 years ago

I think for GT devices @mitchej123 added a method to save/restore fluids using strings instead of fluid IDs. Guess AE2 doesn't do it that way.

Dream-Master commented 4 years ago

Maybe @DeForce can help us here?

observeroftime01 commented 4 years ago

Mitch did fix SFM so that the fluid is stored as a string rather than by ID that prevents this very problem from messing up your SFM setups. Works great by the way. Not sure if the same fix can be applied to EC2 stuff, would be nice for sure.

DeForce commented 4 years ago

I'll investigate, but there should be no "fluid mixup" things between the versions, only if moved from old version that broke liquids

drayath commented 4 years ago

Just done a search on my base, all ae2 'fluid export buses' and 'fluid storage buses' seem to be fine (they have correctly retained their fluid filter type)

It seems to be just the 'fluid interfaces' that have issues.

DeForce commented 4 years ago

@drayath thank you, I'll check why that could be happening

drayath commented 4 years ago

Likely a similar issues but the Gregtech Fluid Filter covers also appear to lose there fluid filter type on game upgrade.

mitchej123 commented 4 years ago

The cover issue has already been resolved

On Wed, Nov 6, 2019 at 11:25 AM drayath notifications@github.com wrote:

Likely a similar issues but the Gregtech Fluid Filter covers also appear to lose there fluid filter type on game upgrade.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GTNewHorizons/NewHorizons/issues/5069?email_source=notifications&email_token=AAOOSIIVNRJHXVXDRVBHNBTQSMK2TA5CNFSM4JG76PQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHWK6Q#issuecomment-550462842, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOOSIMKDUNL5IR2TG6WORDQSMK2TANCNFSM4JG76PQA .

richardhendricks commented 4 years ago

Still need help on the ExtraCells 2 issue

Dream-Master commented 4 years ago

@DeForce can you help us here please. thanks