search

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
980 stars 299 forks source link

Forestry Yield trait doesn't seem to work properly. #5131

Closed richardhendricks closed 4 years ago

richardhendricks commented 4 years ago

After breeding plums (high yield) and mixing them with my butternuts (average yield) I expected a 50% increase. Average yield is supposed to be ~20% chance of fruit, with high yield at 30%. However, after testing, I see essentially no yield difference between the average and high yield trees. 2019-12-02_20 28 11 2019-12-02_20 29 10

richardhendricks commented 4 years ago

Could be an issue with ExtraTrees? Not sure where Butternuts come from.

richardhendricks commented 4 years ago

Yeah, looks like ExtraTrees does a 5x yield chance increase (!). This probably needs to be changed.

https://github.com/ForestryMC/Binnie/blob/master-MC1.7.10/src/main/java/binnie/extratrees/genetics/ExtraTreeFruitGene.java#L378

Dream-Master commented 4 years ago

I can fork it

Dream-Master commented 4 years ago

@richardhendricks https://github.com/GTNewHorizons/Binnie

richardhendricks commented 4 years ago

Thanks @Dream-Master

richardhendricks commented 4 years ago

@mitchej123 What are your thoughts here? I think the High yield trait should return what we get now, with the Average about 65% of that. So if there is a setup with average or below yield, it will get a hit. I don't think it's a big deal since getting Plum isn't that hard, and/or adding a few more trees isn't a big deal.