GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
977 stars 299 forks source link

Add this Backported Patch that fixes entities tracking to prevent duping/vanishing Minecarts and other entities. #5406

Closed StoneLegion closed 3 years ago

StoneLegion commented 4 years ago

The Actual code fix in 1.12.2: https://github.com/MinecraftForge/MinecraftForge/pull/5160

The Backport: https://github.com/Itaros/minecraft-backport5160

The Compiled Jar: https://github.com/Itaros/minecraft-backport5160/releases

This helps fix the tracking of entities and helps if not fully prevents the whole duping and vanishing of entities. The biggest complaint that I have seen that it would fix is Steve Carts, Railcraft Stuff vanishing and or even duping.

It can be server side as well from my understanding so you can throw this onto one the test servers without a Client Patch to test first.

I tested it for quite a while but it should be tested in a more active live development like people with tech, minecarts, etc. That being said I saw no vanishing or duping of entities that being said it's a rarer bug to begin with but not rare as in you never see it but rare enough you can't easily repeat it.

richardhendricks commented 4 years ago

@Hakameda Have you tested this with RailWorld?

StoneLegion commented 4 years ago

I don't suggest this patch at this time due to a shuttering issue I found on the client side: https://github.com/Itaros/minecraft-backport5160/issues/1

RupticMC commented 4 years ago

Hello, the backport seems to crash my 1.7.10 Thermos/Uranium server. The log that I get is https://paste.helpch.at/ehekehinof.md

Am I installing this incorrectly?

I am trying to use this since I switched to Uranium from Thermos, some blocks are disappearing that players have placed down.

Sorry that this does not regard NewHorizons directly. Please let me know if I need to remove my message!

draknyte1 commented 4 years ago

Non-forge environments are not supported. They’re “Use at your own risk”.

Itaros commented 4 years ago

Does it happen if installed server-side only?

Prometheus0000 commented 3 years ago

Can be reopened if someone wants to.