GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.01k stars 307 forks source link

BW fluids don't work in sfm #5646

Closed 0lafe closed 3 years ago

0lafe commented 4 years ago

Which modpack version are you using?

2.0.8.3.smth

What do you suggest instead/what changes do you propose?

When you try to specify a few BW fluids, the filter changes to something else. Trying filter acidic iridium solution will switch to biogass for example. Acidic osmium becomes pahoehoe and CaCl2 is uu as well. Could be related to sfm string thing? Idk

GTNH-Colen commented 4 years ago

Yep just encountered this issue myself while testing in SP, very strange behaviour. SeaweedBroth changes to Ethanol for some reason.

Prometheus0000 commented 4 years ago

Couldn't this be used to cheese particular fluids if you figured out the pattern of the changing? That sounds real bad.

KoljaStrohm commented 4 years ago

I have the same issue: Osmium Solution -> sap Rhodium Sulfate -> molten glass Aqua Regia -> Poison

could this be the problem: https://github.com/GTNewHorizons/Steve-s-Factory-Manager/blob/14973c2db4df31f415815dd54bf18b381c23b9c0/src/main/java/vswe/stevesfactory/network/DataBitHelper.java#L35

KoljaStrohm commented 4 years ago

I tested it locally and changed the 10 to a 32. this fixed the issue for me

Prometheus0000 commented 4 years ago

Would it break everyone else's fluid SFM moving that isn't doing BW stuff? Still probably worth it even if it does

Dream-Master commented 4 years ago

@KoljaStrohm can you do a pull request with your fix ? Thanks

Dream-Master commented 4 years ago

sure if it not breaks other stuff.

KoljaStrohm commented 4 years ago

I changed it in a way now such that it only breaks something if someone uses the fluid with the id 0 (don't know witch one it is or if it even exists). I will create a pull request soon.

Dream-Master commented 4 years ago

@KoljaStrohm glease ask for some changes maybe its possible to add it. Thanks

Prometheus0000 commented 3 years ago

So, did this fix it? @0lafe You use SFM all the time, do you have an answer?

0lafe commented 3 years ago

Seems to be fixed

Prometheus0000 commented 3 years ago

Great.