GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
1.01k stars 304 forks source link

suggestion: add a voiding mode for Super/Quantum tanks #7565

Closed Tedtricks closed 2 years ago

Tedtricks commented 3 years ago

Since Super/Quantum chests can void items on overflow using a screwdriver, why not the tanks as well? This would remove the need of GT++ overflow valves

GTNH-Afx237v7 commented 3 years ago

Highly appreciated. @Tedtricks suggest you update the issue title as this is not a fix but an additional feature for GT tanks.

alphaNOVAircraft commented 3 years ago

Maybe just add it to quantum tanks. There are plenty of ways (that dont require gt++) to have such a voiding. Making everything aviable by default is to simple imo

Eason134HK commented 3 years ago

Since Super/Quantum chests can void items on overflow using a screwdriver, why not the tanks as well? This would remove the need of GT++ overflow valves

Excellent suggestion

Prometheus0000 commented 3 years ago

Honestly I feel that the functionality should be removed from the chests and made a cover. It's just too easy. At least if it's a cover, you have to pay a little extra.

NeroOneTrueKing commented 3 years ago

One -- I'd rather if there was a tierless basic "voiding overflow" cover that was one-size-fits-all: if the tank were to receive more fluid in than it can hold, it voids the excess, and the tank always appears like it can get more fluid added (like a voiding storage drawer).

Two -- I'd like a tiered fluid overflow cover that would do what the original request for the overflow covers would do: https://github.com/alkcorp/GTplusplus/issues/362#issuecomment-417967627. Preferably, it would have a GUI like fluid regulators do.

johnch18 commented 3 years ago

I really wish there was a simple cover that just voids the excess of whatever it's attached to like how multis do natively. The GT++ overflow valves are really cumbersome to use and IMHO poorly implemented.

GTNH-Afx237v7 commented 3 years ago

Maybe it just needs its own little quest if it doesn’t already have one.

Prometheus0000 commented 3 years ago

The OF cover has one, next to the LV assembler.

Glease commented 3 years ago

One -- I'd rather if there was a tierless basic "voiding overflow" cover that was one-size-fits-all: if the tank were to receive more fluid in than it can hold, it voids the excess, and the tank always appears like it can get more fluid added (like a voiding storage drawer).

It's near possible codewise without modifying every addons' machine out there. They need to be aware of this cover and continue to operate despite output tank being full. Some simpler addon machine wouldn't need modifying, but I'd guess lots of them do. It's doable codewise (thanks @mitchej123), now it becomes the same problem as below. Textures?

Two -- I'd like a tiered fluid overflow cover that would do what the original request for the overflow covers would do: alkcorp/GTplusplus#362 (comment). Preferably, it would have a GUI like fluid regulators do.

Basically you want a safety valve. That can be trivially achieved with a dense red crystal, a machine controller, a fluid detector and a pump cover, though admittedly it's quite bulky and sometimes you run out of faces to place the covers. If you, or anyone else interested, can somehow come up with a good texture (item icon and block texture) I can do the coding.

Prometheus0000 commented 3 years ago

BTW, what would this mean for the TFFT? Completely useless? I'd much rather have a cool multi for this.

johnch18 commented 3 years ago

Isn't the TFFT notoriously buggy?

Prometheus0000 commented 3 years ago

Which bot keeps fixing. I'm not sure it has any right now?

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

bombcar commented 2 years ago

https://github.com/GTNewHorizons/GTplusplus/pull/40 May improve the GUI enough for overflow as to make this not necessary.

combusterf commented 2 years ago

If we want to stick with GT++, then higher tier overflow valves would be needed as well. The current maximum is IV tier, which has about the same capacity as a Quantum tank 2, so it doesn't make sense to craft higher tier tanks after that if you intend to void excesses.

That said, I do prefer the screwdriver option.

bombcar commented 2 years ago

Iirc a supertank voiding option is being worked on but currently turns them into infinite tanks.