search

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
980 stars 299 forks source link

Game crashing #7959

Closed Pxx500 closed 2 years ago

Pxx500 commented 3 years ago

Which modpack version are you using?

2.1.0.6b and 2.1.0.7a and 2.1.1.0 #

If in multiplayer; On which server does this happen?

Private #

What did you try to do, and what did you expect to happen?

Crash happens randomly, usually when walking. Never happened on 2.1.0.0 but after going to dev crashes are happening pretty often.

What do you suggest instead/what changes do you propose?

Fix #

What is your GTNH Discord username?

Pxx500

crash-2021-05-22_16.53.37-client.txt

Prometheus0000 commented 3 years ago

Did you get the fixes though?

Alastors commented 3 years ago

Pxx did you have optifine in the folder? Optifine does that sometimes, mytown also does that, delete both

Pxx500 commented 3 years ago

Did you get the fixes though?

What fixes?

Prometheus0000 commented 3 years ago

Go search discord for them.

Pxx500 commented 3 years ago

I'm not sure if this is the fix you are talking about http://jenkins.usrv.eu:8080/job/Gregtech-5-Unofficial/1245/ but the game still crashes

Prometheus0000 commented 3 years ago

If you're using a server did you update myessentials? Other than that the other fixes should be in 7a, so it's a new one or one I don't know.

Pxx500 commented 3 years ago

Server doesn't have my essentials and optifine was running on version 2.1.0.0 and since it helps my FPS a lot I'm reluctant to delete it

StoneLegion commented 3 years ago

There might not actually be enough in that crash to figure out the crash. This looks like a night optifine vs something conflicting. I guess the biggest question is you using any those silly OptiFine tweaks like threaded chunk, etc? Their known to break very badly.

I still think you should try to repeat said crash without optifine. I mean your render distance alone is set too high, even though your on a server it will be lower it can still buffer around when moving.

Pxx500 commented 3 years ago

crash-2021-05-24_20.50.53-client.txt My friend is also experiencing crashes even though he doesn't have optifine.

StoneLegion commented 3 years ago

@mitchej123 Not sure if you want to check this out before 2.1.1.0

botn365 commented 3 years ago

ConcurrentModificationException this looks like a pain to figure out what would cous this

StoneLegion commented 3 years ago

Your Java Version is quite Outdated 1.8.0_51 not saying this would fix it, but it's quite outdated. I think were 292? To give you an idea how far behind it is.

Prometheus0000 commented 3 years ago

this looks like a pain to figure out what would cous this

Yes, but it's a regression, so we should at least try, since we don't want an update that causes people to crash all the time. Or at least some people.

Dream-Master commented 3 years ago

I packing the mod folder twice in the pack. Maybe that is the issue. I reupload the file now.

StoneLegion commented 3 years ago

I packing the mod folder twice in the pack. Maybe that is the issue. I reupload the file now.

I highly doubt it read the folder inside. That being said it's hopeful thinking heh.

Glease commented 3 years ago

@Pxx500 what version of modpack are you using exactly? 2.1.0.7, 2.1.0.7a or 2.1.0.6b?

Pxx500 commented 3 years ago

2.1.0.6b and 2.1.0.7a

Prometheus0000 commented 3 years ago

Could you try going back versions until it stops happening?

Pxx500 commented 3 years ago

2.1.0.0 was fine And checking every version would take long sice you never know when will the crash occur, can take a long time

Prometheus0000 commented 3 years ago

Well, it isn't happening to us, so how do you expect us to fix it without knowing which change over the course of months caused it? At least a version would narrow it down.

Pxx500 commented 3 years ago

Where can I download all the versions?

Glease commented 3 years ago

I'll try code a mod real quick to help narrow down the source of bug.

In mean time let's ask on discord if someone else is also having problems like this.

Glease commented 3 years ago

Please try add this mod to your mods folder. It will not solve the problem, however it'll add a few more lines to crash report and will (hopefully) help narrow down the cause.

Please do remember due to the nature of this bug (randomly happen only to some people) this might not help at all.

StoneLegion commented 3 years ago

@Pxx500 any luck getting it to crash since?

Pxx500 commented 3 years ago

I had GTNH open for 14 hours straight with no luck getting the crash even though yesterday I had 3. But I guess 1:12AM when I'm about to go to sleep is the perfect time for a crash. crash-2021-05-26_01.12.50-client.txt I hope there's something useful in there!

Pxx500 commented 3 years ago

I can see a lot of red text in game log that is similar to the one in the crash log but not exactly the same. In case it's somehow relevant (it's probably not though): Above crash.txt

Glease commented 3 years ago

Did you add the debug mod I mentioned above?

Pxx500 commented 3 years ago

Yes, it's mentioned multiple times in the log from yesterday fml-client-3.log

Hachuurui commented 3 years ago

Have you guys considered using Forge's built in function to delete erroring entities/tile entities to help trace this?

Backup the world. Update the forge.cfg to enable that feature, then wait for it to occur and take note of what blocks/items vanish?

If nothing else, it would help narrow down the mod/blocks involved and give you guys a place to search source code wise. If you have a copy of the world I could also setup a test environment for this. Just hit me up on discord.

Glease commented 3 years ago

@Pxx500 Hi, I have updated DebugMod to make it more reliably produce thread dumps. Could you please try update it and use this jar instead: https://github.com/Glease/DebugMod/releases/download/1.0.2/DebugHelper-1.0.2.jar

Pxx500 commented 3 years ago

log.txt In mod list version of the mod is 1.0.1 if you care about that, but it's not important. @Glease crash-2021-06-03_20.19.12-client.txt And another one (top one is from my friend who I play with)

Glease commented 3 years ago

This is getting on my nerve. why tf it doesn't want to generate the stack trace :(

Glease commented 3 years ago

@Pxx500 Hi, sorry for the ping again. I have updated the mod again in the hope it will properly generate the dump this time https://github.com/Glease/DebugMod/releases/download/1.0.3/DebugHelper-1.0.3.jar I have removed all preconditions. If this still fails then I'd have totally no idea what's going on.

If it succeeds, you'd see your crash report bloated with a lot more text. The Thread Dump line would also not contain Not generated.

Pxx500 commented 3 years ago

crash-2021-06-04_16.45.32-client.txt Unfortunately it didn't generate

Pxx500 commented 3 years ago

Since only I and my friend experience those crashes is it possible that it's server sided? Server doesn't crash though and we never crashed at the same time. @Glease Console doesn't give any information too.

Glease commented 3 years ago

That's really just guessing around who is doing bad. There is 1000 cause for a ConcurrentModificationException and the stack trace isn't at all useful. Even if you limit it to a server side only or client side only problem it's still looking for a needle in a haystack.

I created DebugMod in the hope of it adding thread dump to crashreport, which is a lot more helpful while traking down ConcurrentModificationException than the existing infos in the stack trace. However, well you see, it just doesn't want to work 😢

Pxx500 commented 3 years ago

For some reson I cannot use the map when changing to earlier versions . After loading world the game just goes back to main menu. I tried to use earlier version of my save I saved when going from 2.1.0.0 to dev versions, 2 minecrafts were running for about 20 hours and neither crashed (2.1.0.7 and the other was 2.1.0.2b). I have no clue what to do anymore.