search

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
949 stars 296 forks source link

Stable Update 2.1.2.0 #8791

Closed Dream-Master closed 2 years ago

Dream-Master commented 2 years ago

Your GTNH Discord Username

DreamMasterXXL

Your Pack Version

2.1.2.0

Your Proposal

We need a checklist what need to be done before stable 2.1.2.0 update

Your Goal

We need a checklist what need to be done before stable 2.1.2.0 update

Your Vision

We need a checklist what need to be done before stable 2.1.2.0 update

Final Checklist

GTNH-Afx237v7 commented 2 years ago

Finally close #7847 - new recipe for AE2 storage components - has been PR‘ed long time ago, still no consensus

glowredman commented 2 years ago
yukieiji commented 2 years ago
boubou19 commented 2 years ago
Dream-Master commented 2 years ago

Finally close #7847 - new recipe for AE2 storage components - has been PR‘ed long time ago, still no consensus

Because I don’t merge it in this stage.

Cata-bre commented 2 years ago

Edit: I don't know how to link correctly apparently; I can't get the green circle. Edit by maintainers: Fixed format for ya

GTNH-Afx237v7 commented 2 years ago

Because I don’t merge it in this stage.

Yes that is what I mean - we need to find and agreement on the recipe, then merge, then close.

bombcar commented 2 years ago
bombcar commented 2 years ago

Edit: I don't know how to link correctly apparently; I can't get the green circle.

- [ ] #8611

Steelux8 commented 2 years ago 
  Given the aluminum change we should also include the proposed kanthal down-tier

Looking at how the alum line is right now, this is essential. The EBF steps unlocked at LV to get aluminium and into the MV tier can only be changed at early-mid HV, after making a cleanroom, the HV circuit chain and the vac freezer. During MV, you have to keep using the LV EBF recipes.

Dream-Master commented 2 years ago 
  Given the aluminum change we should also include the proposed kanthal down-tier

Looking at how the alum line is right now, this is essential. The EBF steps unlocked at LV to get aluminium and into the MV tier can only be changed at early-mid HV, after making a cleanroom, the HV circuit chain and the vac freezer. During MV, you have to keep using the LV EBF recipes.

No it is not. Alu change works well with old coils in hv.

Steelux8 commented 2 years ago

No it is not. Alu change works well with old coils in hv.

How so? Carbon Dust can't be used with Alumina until post-vac freezer, and the same goes for smelting Aluminium Dust directly.

Dream-Master commented 2 years ago

Alumina + cryolite much cheaper than before

Dream-Master commented 2 years ago

Lv

Steelux8 commented 2 years ago

Even if that's true, according to this chart I'm looking at, electrolyzing Alumina for Aluminium Dust and Oxygen can be done in an HV electrolyzer (unlocked with stainless steel) but it can only be processed after 2 new multis are built and the new circuit line has been started.

Kanthal Coils even say in the tooltip that they are MV. I don't see any reason for them not to be, especially after the aluminium change.

draknyte1 commented 2 years ago

As it’s stood for a long time, kanthal coils are pointless. As soon as you make them, you just make nichrome straight away. Moving them to actual MV makes lots of sense.

Dream-Master commented 2 years ago

Sure the kanthal buff is maybe a good change but it is not necessary because of the aluminium change.

bombcar commented 2 years ago

Sure the kanthal buff is maybe a good change but it is not necessary because of the aluminium change.

True, as long as the cryolite is fixedindev the people who are late LV/early MV can use that. I'll note it on the Upcoming Changes page (which will become the wiki release page).

bombcar commented 2 years ago
Savallator commented 2 years ago

Whoever included the AMDIForge-mod again (see #3204), can it be removed again? Since it is in 2.1.1.4QF2 currently and therefore Magnum torches are broken there.

bombcar commented 2 years ago
slprime commented 2 years ago

I can fix this issues

D-Cysteine commented 2 years ago

Some more suggestions, some of which might be too much work though:

I could go through and try to compile a list of bugged recipes in 2.1.1.4, if desired, though there are very, very many.

iouter commented 2 years ago

and update the nee.

GTNH-Afx237v7 commented 2 years ago
Dream-Master commented 2 years ago

remove or make the platinum you get via Molecular Transformer more expensive

Glease commented 2 years ago 
* [ ]  Mark quests secret, and re-enable showing the view mode button by default in the quest book

@D-Cysteine What else is needed on this subject? IIRC it's feature complete and merged already?

D-Cysteine commented 2 years ago 
* [ ]  Mark quests secret, and re-enable showing the view mode button by default in the quest book

@D-Cysteine What else is needed on this subject? IIRC it's feature complete and merged already?

Currently, the view mode button (not view mode itself, but rather the button toggling it) is hidden by default, because there are some quests that it would show, which we actually want to hide even from view mode.

We need to actually go through the questbook and mark any quests that need to be secret with the new SECRET visibility. Then, we need to go into the Better Questing config and enable the view mode button by default. Unfortunately, I don't know which quests need to be secret. @Dream-Master might know?

Dream-Master commented 2 years ago 
* [ ]  Mark quests secret, and re-enable showing the view mode button by default in the quest book

@D-Cysteine What else is needed on this subject? IIRC it's feature complete and merged already?

Currently, the view mode button (not view mode itself, but rather the button toggling it) is hidden by default, because there are some quests that it would show, which we actually want to hide even from view mode.

We need to actually go through the questbook and mark any quests that need to be secret with the new SECRET visibility. Then, we need to go into the Better Questing config and enable the view mode button by default. Unfortunately, I don't know which quests need to be secret. @Dream-Master might know?

I dint have the time for set quests to be secret and enable view mode again. Will do this after the 2.1.1.5 dev version

Dream-Master commented 2 years ago

Finally close #7847 - new recipe for AE2 storage components - has been PR‘ed long time ago, still no consensus

done

Dream-Master commented 2 years ago

will be done after release

Dream-Master commented 2 years ago

Done

Dream-Master commented 2 years ago

Done

Dream-Master commented 2 years ago

I can fix this issues

@mitchej123 can you add this or is this just for next release ? (first checkbox)

Dream-Master commented 2 years ago

Some more suggestions, some of which might be too much work though:

  • [ ] Mark quests secret, and re-enable showing the view mode button by default in the quest book
  • [ ] Fix as many colliding / bugged recipes as we can
  • [ ] Decide on what we want to do for #gc-o2-lox-rework and implement it?

I could go through and try to compile a list of bugged recipes in 2.1.1.4, if desired, though there are very, very many.

Will add the secret quest stuff tomorrow

Dream-Master commented 2 years ago

and update the nee.

@iouter let me know when it is done

iouter commented 2 years ago

and update the nee.

@iouter let me know when it is done

i think these are all done and can be used Just Enough Calculation Not Enough Energistics

bombcar commented 2 years ago

In checking the current zip I noted the following are either not on Jenkins or are outdated in the zip/jenkins:

NEI-Integration (has code fixes) Biomes of Plenty StorageDrawers (got split into five, but the "original" unuqdated one is still there WitcheryExtras (has code changes) BloodMagic (has code changes, renamed master)

Savallator commented 2 years ago

Could we maybe get this #8806 into 2.1.2.0 ? It would be a small change, but help a lot with scalability and especially server performance.

boubou19 commented 2 years ago

2.1.2.0 came out this night, so nope, sorry. Maybe in the next one.

Savallator commented 2 years ago

Oh lol, sorry, too late^^ I was deceived by this issue being still pinned lol