GT++ coke oven and extruder multis don't form after the update

crszpth commented 2 years ago

Your GTNH Discord Username

Crszpth#2445

Your Pack Version

2.1.2.0

Your Server

SP

Type of Server

No response

Your Expectation

On 2.1.1.0 the advanced coke oven and the industrial extruder were working and forming correctly

The Reality

After the 2.1.2.0 update the controllers give the "Incomplete structure" error

Your Proposal

Tried the jar #139 fix on jenkins and the multis are still not forming. My guess is that the structure checkfix needs to be extended to the industrial coke oven and the extruder multis

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[x] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

draknyte1 commented 2 years ago

Check your casing count for extruder.

Coke oven needs 8 casings and only acceptd

if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_InputBus){
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_Maintenance){
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_Energy){
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_OutputBus) {
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_Muffler) {
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_Input) {
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            } else if (aMetaTileEntity instanceof GT_MetaTileEntity_Hatch_Output) {
                return addToMachineList(aTileEntity, aBaseCasingIndex);
            }

boubou19 commented 2 years ago

did you checked with the structurelib blueprints? they have stricter forming conditions now. Just managed to get to form an industrial extruder and the industrial coke oven on 2120.

draknyte1 commented 2 years ago

did you checked with the structurelib blueprints? they have stricter forming conditions now. Just managed to get to form an industrial extruder and the industrial coke oven on 2120.

Some are genuinely broken though Boubs.

boubou19 commented 2 years ago

2021-12-14_20 56 18 2021-12-14_20 57 11

not those ones at least.

crszpth commented 2 years ago

Managed to make the extruder form by moving the muffler off the top layer. Still no luck with the coke oven

draknyte1 commented 2 years ago

Why is the extruder in the floor? lol

boubou19 commented 2 years ago

i put the controller on the ground then shift rclicked on it with a stack of structurelib blueprints, i ended up with the blocks being replaced like that

draknyte1 commented 2 years ago

ICO is definitely broken. Fixed by https://github.com/GTNewHorizons/GTplusplus/pull/68/commits/cea522405123022353b0be936db466c4a87d1877.

GTNewHorizons / GT-New-Horizons-Modpack