Change Plutonium 238 vein height so it can spawn properly

fourk commented 2 years ago

Your GTNH Discord Username

fourk#5436

Your Pack Version

2.1.2.1

Your Server

sp

Type of Server

Single Player

Your Expectation

When visual prospector shows a vein as 'Plutonium' it should contain ores.

The Reality

I have found 4 of these so far on Callisto, all of them have no ores, not even the small ores that should be associated with the vein type.

Your Proposal

Either don't show plutonium as the ore type in visual prospector when those ores don't exist in the marked ore chunk, or spawn the appropriate ores for that vein type.

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

GTNH-Colen commented 2 years ago

Annoyingly I don't think this is actually a bug, the vein would've spawned there but the map wasn't high enough so it couldn't do so. Plutonium spawns at 55-120, so you can see how this easily occurs.

The vein should be moved down but I'm not sure how to do that.

Dream-Master commented 2 years ago

sure i can do that. Which high you suggest? It can interfear with other mixes.

bombcar commented 2 years ago

@SinTh0r4s could visual prospector “realize” a vein failed and not show it?

Dream-Master commented 2 years ago

yes if the vein is to small it not shown or if you digg out most if it it vanished /not shown.

fourk commented 2 years ago

but the map wasn't high enough so it couldn't do so.

This makes sense. I ended up exploring further on Ceres and found 2 more failed veins and then 2 that spawned plutonium. Turns out that there aren't actually any small ores of u238/p239/thorium that spawn even on the successful veins, so the scenario of height failure causing both zero ores and zero small ores may be somewhat unique to this ore type. It sounds like Visual Prospector's detection for the failed u238/p239 veins may not be working as intended/expected (since it DOES hide other veins for me in the overworld that I had mined out before ever updating to 2.1.2.x and adding visual prospector)

Dream-Master commented 2 years ago

@fourk ok which high should be good? 35-65 ?

fourk commented 2 years ago

Yeah, that would cause far fewer failed oregen instances, which seems reasonable given the very low spawn weight of the vein.

bombcar commented 2 years ago

Too bad it can’t try to spawn high as a rich vein, and failing that try low as a poor vein

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

GTNewHorizons / GT-New-Horizons-Modpack