GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
907 stars 284 forks source link

Overflow valve void output based on input volumes #9561

Open Loreili opened 2 years ago

Loreili commented 2 years ago

Your GTNH Discord Username

Loreili#5457

Your Pack Version

2.1.2.0

Your Server

Private Server

Type of Server

Don't know

Your Expectation

When adding an overflow cover to a machine, the output fluid should be voided if it exceeds the set threshold.

The Reality

When adding an overflow cover to a machine, if the input fluid exceeds the configured threshold, the output fluid is voided.

This can be demonstrated using an LV Electrolyser filled with water as an input to create oxygen cells and hydrogen fluid (Circ 1). If the overflow cover is set to 64000, no fluids are voided. If the cover is set to any value below 64000, any hydrogen which is created is immediately voided.

Your Proposal

Fluid voiding in machines should only occur based on the volume of output liquid, not the input.

Tanks should continue to void based on the only liquid inserted.

Final Checklist

chochem commented 1 month ago

still an ongoing issues