GTNewHorizons / GTNHLib

GTNH Library
GNU Lesser General Public License v3.0
13 stars 7 forks source link

Port configs from Angelica/ArchaicFix #23

Closed Caedis closed 9 months ago

Caedis commented 10 months ago

This will allow our mods to easily create config files as well as allow them to be editable in game from the Forge config menu.

Should we also move this to here or even HP? https://github.com/GTNewHorizons/EnderCore/blob/master/src/main/java/com/enderio/core/client/gui/bettermodlist/EventHandlerGui.java

This allows the forge config gui to work in game.

Glease commented 10 months ago
  1. lombok? if possible, at least make sure it doesn't got passed down the dependency chain
  2. where does this piece of code come from? I'd imagine it's not yours code, nor code of anyone inside GTNH org. proper credit need to be given somehow
Caedis commented 10 months ago

It all came from https://github.com/GTNewHorizons/Angelica/tree/master/src/main/java/com/gtnewhorizons/angelica/config so ask @mitchej123

Caedis commented 10 months ago

How would I make sure deps dont add it?

Caedis commented 10 months ago

Looks like the original source is FalsePatternLib, which is LGPL-3 https://github.com/FalsePattern/FalsePatternLib/tree/master/src/main/java/com/falsepattern/lib/config after going through Angelica -> AF -> FalsePatternLib

bombcar commented 10 months ago

How would I make sure deps dont add it?

According to https://wiki.gtnewhorizons.com/wiki/Development#Dependency_types you have the right one, it shouldn't be pulled into further things downstream.

mitchej123 commented 9 months ago

Should probably add something to Credits indicating where it came from and the license. I didn't realize it came to AF via FPL or I would have included that in Angelica's credits.

mitchej123 commented 9 months ago

Yah, talked to FP - he's fine with it going here, but let's put a mention in the credits/readme giving them credit

Caedis commented 9 months ago

I actually had that ready to commit/push for awhile