search

GTNewHorizons / Hodgepodge

A HodgePodge of patches
GNU Lesser General Public License v3.0
36 stars 57 forks source link

Causes Campfire Backport's animation to not work. #204

Open MagmaBro123 opened 1 year ago

MagmaBro123 commented 1 year ago

Title. See video and modlist below.

image

https://user-images.githubusercontent.com/51277766/227800651-03fbd714-63f4-4b2f-9c68-d34692142acf.mp4

Omgise commented 1 year ago

try disabling speedupAnimations in config and check if it fixes the issue

MagmaBro123 commented 1 year ago

Not sure why it took 3 weeks for a response, but yeah, disabling that fixes this. A proper fix would be nice though.

connor135246 commented 11 months ago

Part of this is an issue in Hodgepodge. I believe the fire isn't being animated because of #264. This is probably a simple fix.

Part of this is kind of my fault. I believe the embers on the logs aren't animated because... I don't actually use the renderFace methods in RenderBlocks that the injection here points to. Even if I did go back to using the traditional renderFace methods to fix this, I also have a custom crossed squares method that uses two icons which would still be broken (I use this in NEI to represent recipes that work for both types of campfires). So I don't see a simple fix. API for speedupAnimations? Nah, probably just an annoyance you'll have to accept.

mitchej123 commented 7 months ago

We'll likely add an API for speedupAnimations as mentioned, but for now we'll work around it in Angelica (which is where this was moved to)