GTNewHorizons / JustEnoughCalculation

A simple minecraft mod help you calculate the cost for recipes
Other
5 stars 5 forks source link

Add support for calculating multiple items #14

Closed Bmandk closed 1 month ago

Bmandk commented 1 month ago

Implements https://github.com/GTNewHorizons/JustEnoughCalculation/issues/13

This feature allows players to add multiple items to the calculator. This is useful if players want to batch craft multiple items at the same time that all use the same components.

For example, if a player wants to craft robot arms and conveyors, they will need several motors. Instead of having to calculate them by themselves, they can now do it in one go.

Here's a short video showing the feature in action with vanilla items.

https://github.com/user-attachments/assets/31f80228-e89d-4be6-ae33-a825aeec514a

Caedis commented 1 month ago

can you run the spotlessApply task and push the changes please?

Bmandk commented 1 month ago

Just pushed it, thanks

Caedis commented 1 month ago

Probably not going to like the wildcard import

Bmandk commented 1 month ago

Ah, must have been my IDE as it automatically handles that. I'll revert that part so it only imports what's needed.

Bmandk commented 1 month ago

Third time's the charm

Bmandk commented 1 month ago

Fixing...

Caedis commented 1 month ago

If it fails again, i should be able to push changes to it

Bmandk commented 1 month ago

Yeah this time it seems to have failed due to a problem I also had locally, but I found a workaround by replacing

        clientSide = Tags.GROUPNAME + ".network.ClientProxy",
        serverSide = Tags.GROUPNAME + ".network.CommonProxy")

with

        clientSide = "me.towdium.jecalculation.network.ClientProxy",
        serverSide = "me.towdium.jecalculation.network.CommonProxy")

in JustEnoughCalculations.java... I'm not sure whether this is intended, since it's also what's on master currently.

Caedis commented 1 month ago

I got it

Bmandk commented 1 month ago

Thanks for the help!