GTNewHorizons / NotEnoughItems

GNU Lesser General Public License v3.0
51 stars 74 forks source link

Fix history panel being hidden when centered search and no quantity widget #468

Closed Caedis closed 7 months ago

Caedis commented 7 months ago

Fixes https://github.com/GTNewHorizons/NotEnoughItems/issues/467

slprime commented 7 months ago

why ignored my comment?

Dream-Master commented 7 months ago

@slprime so it wasnt a bug it was just disabled ?

Caedis commented 7 months ago

@slprime what comment?

slprime commented 7 months ago

image

Caedis commented 7 months ago

Its still pending, you never submitted it.

slprime commented 7 months ago

ups. I was in a hurry to work

Caedis commented 7 months ago

Also, did you try it in game? I tried all permutations of the 2 settings and it looked good

and as I typed that, I noticed the issue. I am not checking if the history panel is shown when returning the footer size

Caedis commented 7 months ago

no, line 199 handles that

slprime commented 7 months ago

yes, I checked. You might not have noticed that the margin at the top and bottom is slightly different depending on the settings (2 pixels difference)