GTNewHorizons / ServerUtilities

GNU Lesser General Public License v3.0
29 stars 14 forks source link

Manual server backup bug #33

Closed Novie53 closed 8 months ago

Novie53 commented 9 months ago

If you try 1) start a manual backup from the server console and 2) the need_online_players is enabled and 3) no player is online

you receive a notifikation "[Server thread/INFO]: Server launched a manual backup!" but nothing happens.

[forewarn novice programmer] I think it can be solved by 1) changing this line to include some kind of server class. 2) this line should be change to if (!hasOnlinePlayers() && !hadPlayer) return false;.

side note. What is the purpose of the hadPlayer boolean? I can only find referens for it in two files (backups.java and ServerUtilitiesPlayerEventHandler.java) and neither use it for anything except change its value.