search

GTNewHorizons / ServerUtilities

GNU Lesser General Public License v3.0
29 stars 14 forks source link

[Draft] - Primary Addin and rewrite of functions in Serverlib #5

Closed Ethryan closed 1 year ago

Ethryan commented 1 year ago

Looking for assistance to port this and update the ServerUtilities with newer features.

Nice to haves: serverutils.integration <-- NEI, Journeymap and so on. Needs to be written from scratch.

Ethryan commented 1 year ago

Now if I only could get the icons to load...

Ethryan commented 1 year ago

Aurora is set to be disabled by default

Ethryan commented 1 year ago

Aurora is not working right now, it only shows a white page on startup, but at least it should work after some troubleshooting.

Lyfts commented 1 year ago

Backup command works, need to add the auto backup. All of it could also use a cleanup.

Ethryan commented 1 year ago

Major bug left: All commands seems to be added twice to the command list. Probably the same issue that the buttons had about being added twice, so something is calling the client function twice somehow.

Ethryan commented 1 year ago

The Aurora Config still needs fixing, the Enum values can't be set, and i can't get it to work...

Ethryan commented 1 year ago

TODO: Create a way to Authorize users so that they can access the Requires_Auth pages. <-- no clue how to do this.

Lyfts commented 1 year ago

The problem with commands seem to be here:

The problem was not here https://github.com/GTNewHorizons/ServerUtilities/blob/4f6d13c8d11a4f09b743284f3f7b7b77da907814/src/main/java/serverutils/utils/ServerUtilities.java#L115-L128

It seems to got through that once per mod in the package for whatever reason. Just like the sidebar buttons.

Ethryan commented 1 year ago

Damn, at least you found the root of the issue

Lyfts commented 1 year ago

This will crash on server startup with AromaCore loaded (and presumably more)

this https://github.com/GTNewHorizons/ServerUtilities/blob/2684331b1e513ce0cacc7ecfd7c9c3c4a972de0f/src/main/java/serverutils/utils/ranks/CommandOverride.java#L41-L50

crash-2023-10-03_14.28.44-server.txt

Some more minor bugs: The [Click Here] to turn notification off that shows when you join a server and aren't in a team doesn't work. Sidebar buttons doesn't show in NEI creative+ inventory. (its not an instance of InventoryEffectRenderer) The config option "show_playtime" is hilariously off. The nbt and trash can keybinds don't work no matter which key you set it to.

Ethryan commented 1 year ago

Closing this since a new pull request has been made.