GTNewHorizons / ThaumicHorizons

Authorized Continuation
GNU Lesser General Public License v3.0
7 stars 19 forks source link

Crash with GT6 #46

Closed unix-supremacist closed 4 months ago

unix-supremacist commented 1 year ago

mod improperly assumes if the gregtech modid is loaded that gt5 is loaded, when gt6 and gt5 both share the same id

https://pastebin.com/9FPWYYiw

Alastors commented 1 year ago

mod improperly assumes if the gregtech modid is loaded that gt5 is loaded, when gt6 and gt5 both share the same id

https://pastebin.com/9FPWYYiw

OOF, that's rough bud, I'll see what I can do when the coffee hits

Yoghurt4C commented 1 year ago

the simple solution would be to move the codeblock into a separate class along with imports to avoid interference and check if (Loader.isModLoaded("gregtech") && !Loader.isModLoaded("gregapi") before calling it

Alastors commented 1 year ago

the simple solution would be to move the codeblock into a separate class along with imports to avoid interference and check if (Loader.isModLoaded("gregtech") && !Loader.isModLoaded("gregapi") before calling it

Yeah great idea, that's exactly what I'm going to do lmfaoooo, though I probably won't duplicate the support GT5 offers since I don't personally use 6

SilearFlare commented 1 year ago

hello yes hi you can fix with yogurtmethod yes good?

SilearFlare commented 1 year ago

ser SER please SER TWO MONTHS SER

Alastors commented 1 year ago

ser

SER please SER

TWO MONTHS SER

hello yes hi you can fix with yogurtmethod yes good?

First off the "yoghurt method" means absolutely nothing to me.

Second off, I'm the only dev currently working on this mod, I just finished moving and came off hiatus, you don't need to be rude, I have multiple other mods I'm working on. Development in my free time can be slow at times.

SilearFlare commented 1 year ago

the simple solution would be to move the codeblock into a separate class along with imports to avoid interference and check if (Loader.isModLoaded("gregtech") && !Loader.isModLoaded("gregapi") before calling it

's this thing

Alastors commented 1 year ago

the simple solution would be to move the codeblock into a separate class along with imports to avoid interference and check if (Loader.isModLoaded("gregtech") && !Loader.isModLoaded("gregapi") before calling it

's this thing

Oh lmfao, thank you darling, yeah I'll look at it when I wake up, writing it down on my notepad now

Rimusp commented 1 year ago

As Magic bees does not have an Issues tab (or am i just dumb?) im asking here. Gt6 crashes with magic bees and i think it might be a similar issue but as i dont have any idea of java i might be completely wrong lol

SilearFlare commented 1 year ago

You are partially correct. Magic bees crashes because of the same issue (Gregtech getting called vs gregapi) yes.

Specifically this commit https://github.com/GTNewHorizons/MagicBees/commit/d9ef30fe32a71eb91bde9542c8fa52c4d2aa7ef1.

thePalindrome commented 11 months ago

Is anybody working on this, or should I do the PR, relearn the toolchain, and add in a simple version check?

(The number is in the mod info, you just have to check that it's 5 and not 6 for the major)

GregoriusT commented 11 months ago

Sorry for Past Greg being too stupid to change the darn Mod ID. XD

SilearFlare commented 11 months ago

Is anybody working on this, or should I do the PR, relearn the toolchain, and add in a simple version check?

Issue opened on june 28th It is now October 9th No commits have been made Go for it

thePalindrome commented 11 months ago

Sorry for Past Greg being too stupid to change the darn Mod ID. XD

Well, you updated the mod version number, so it works :P

Abalieno commented 11 months ago

As far as I know Thaumic Horizons loads fine with GT6.

Current incompatibilities are Thaumic Bases, EMT, Witching Gadgets, all for similar reasons.

SilearFlare commented 11 months ago

As far as I know Thaumic Horizons loads fine with GT6.

That is technically correct, but also completely wrong. This is a crash pertaining the pocket plane option in ThaumicHorizons.cfg, which is, admittedly, disabled by default (although mostly for stability, it has actually been fleshed out and reworked extensively enough that it is a pretty interesting part of the mod in of itself): B:enablePocketPlane=false The moment you enable that option, it will call for GT5 ores because they share the same ID, and it will crash if you have gt6 installed. The solution to fix this is actually quite trivial, as it has been pointed out, stop calling gregtech and call gregapi instead.