GTNewHorizons / ThaumicHorizons

Authorized Continuation
GNU Lesser General Public License v3.0
7 stars 19 forks source link

Removed GT dependency on Pocket Plane #52

Closed DrParadox7 closed 1 year ago

DrParadox7 commented 1 year ago

Pocket Dimensions are no longer locked behind GT being present, only its custom recipes added in PR #13.

With GT (tested with GTNH v 2.3.2): image image

Without GT: image image

DrParadox7 commented 1 year ago

Oh, I just noticed. This closes issue #47

Alastors commented 1 year ago

13

I need you to confirm that you have for fact tested this in the pack, (GTNH, no where else, though that is a nice optional bonus) and that it works.

The code itself looks fine, seems like a weirdly random addition from years gone past.

Alastors commented 1 year ago

13

I need you to confirm that you have for fact tested this in the pack, (GTNH, no where else, though that is a nice optional bonus) and that it works.

The code itself looks fine, seems like a weirdly random addition from years gone past.

I will say it seems like you have, but I need you to confirm this was in the full pack and not just a smaller cut version of it or anything else

DrParadox7 commented 1 year ago

13

I need you to confirm that you have for fact tested this in the pack, (GTNH, no where else, though that is a nice optional bonus) and that it works. The code itself looks fine, seems like a weirdly random addition from years gone past.

I will say it seems like you have, but I need you to confirm this was in the full pack and not just a smaller cut version of it or anything else

I have tested it specifically with the latest GTNH version I could find on Technic through MMC. Here are the logs if you need physical proof: fml-client-latest.log

Alastors commented 1 year ago

13

I need you to confirm that you have for fact tested this in the pack, (GTNH, no where else, though that is a nice optional bonus) and that it works.

The code itself looks fine, seems like a weirdly random addition from years gone past.

I will say it seems like you have, but I need you to confirm this was in the full pack and not just a smaller cut version of it or anything else

I have tested it specifically with the latest GTNH version I could find on Technic through MMC.

Here are the logs if you need physical proof:

fml-client-latest.log

Aight, that should be good then.

SilearFlare commented 1 year ago

I was thinking that this would be the commit that finally fixes the crash on startup when enabling pocket planes with a version of GT that isn't 5U installed, but I would just like to note that the game still crashes when using GT6 when the pocket plane is enabled, because the mod :eyes: "GT" and calls for GT5U ores. See crashlog here: https://pastebin.com/3zbG8kUb Maybe a check for GT5U instead of a blanket GT check could fix this?

Edit: Actually didn't notice the issue that was opened about this last week! :smile: So this was technically redundant and in the wrong place, but still, it's been a bug for a few years now, so I'm glad it's being addressed.

Alastors commented 1 year ago

I was thinking that this would be the commit that finally fixes the crash on startup when enabling pocket planes with a version of GT that isn't 5U installed, but I would just like to note that the game still crashes when using GT6 when the pocket plane is enabled, because the mod 👀 "GT" and calls for GT5U ores. See crashlog here: https://pastebin.com/3zbG8kUb Maybe a check for GT5U instead of a blanket GT check could fix this?

Yeah so this isn’t that just yet, this is fixing a separate issue lmfao, I will get to your issue by Wednesday if no one else has by then