search

GTNewHorizons / TinkersConstruct

Tinker a little, build a little, tinker a little more...
GNU Lesser General Public License v3.0
10 stars 42 forks source link

Revert default config for option "Remove Gold Cast Recipes" #130

Closed wlhlm closed 3 days ago

wlhlm commented 4 days ago

Just changes the default to the old value. Doesn't affect GTNH as it is already set there explicitly:

https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/blob/10628584857b5a973d4b45a446a87dcd7746754e/config/TinkersConstruct.cfg#L36

Fixes #128

Dream-Master commented 3 days ago

But why ? If the config is accidentally removed gold cast will spawn ?

chochem commented 3 days ago

We support ticon outside of GTNH. There gold should be allowed.

wlhlm commented 3 days ago

But why ? If the config is accidentally removed gold cast will spawn ?

Original TiCon supports making casts with gold. The config option "Remove Gold Cast Recipes" was added in our fork. Our TiCon fork is meant to be used outside of GTNH, and for that purpose we should keep the default behavior. We can change the setting in our config if we want to have it set to a different value (and we already do in the GTNH config).

Not sure why we need to consider the case of accidentally removing the config. GTNH will certainly implode if you start randomly removing/resetting config options. That applies to most of the mods, not just TiCon. That's why we have the modpack config in git so that we don't accidentally remove/reset options.