GTNewHorizons / lwjgl3ify

A mod to run Minecraft 1.7.10 using LWJGL3 and Java 17+
GNU Lesser General Public License v3.0
171 stars 37 forks source link

[Crash] Version 1.1.2 crashes with DragonAPI #1

Closed FalsePattern closed 1 year ago

FalsePattern commented 1 year ago

Mod list:

It seems like lwjgl3ify breaks Reika's glsl shader loading code.

fml-client-latest.log

eigenraven commented 1 year ago

Looks like Reika is using the wrong opengl api to get shader linking status: https://github.com/ReikaKalseki/DragonAPI/blob/master/IO/Shaders/ShaderProgram.java#L391-L395 - here the get calls must be glGetProgrami not glGetShaderi, because they operate on the linked program and not individual shaders. See https://docs.gl/gl2/glLinkProgram for reference. Because it seems Reika is still updating mods, it'd be better to get it fixed upstream than me working around the issue.

eigenraven commented 1 year ago

Fixed in recent DragonAPI source updates, the next build should work when that gets released