search

GTNewHorizons / lwjgl3ify

A mod to run Minecraft 1.7.10 using LWJGL3 and Java 17+
GNU Lesser General Public License v3.0
170 stars 37 forks source link

Fix SoundManager handling when no sound devices exist #173

Closed kstvr32 closed 2 months ago

kstvr32 commented 2 months ago

Supersedes GTNewHorizons/Hodgepodge#420 as a fix for the SoundManager NPE crashes

Fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/17190 Fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/17190 Fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/16281 Fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/12848 Fixes https://github.com/GTNewHorizons/Hodgepodge/issues/406

Adds null check that is present in LWJGL2 when initializing OpenAL sound.

Edgars-Cirulis commented 2 months ago

Does that commit resumes the sound?

kstvr32 commented 2 months ago

This changes back to standard 1.7.10 behavior of turning to silent mode.

You can manually reload the sound by pressing F3 + T