search

GTNewHorizons / lwjgl3ify

A mod to run Minecraft 1.7.10 using LWJGL3 and Java 17+
GNU Lesser General Public License v3.0
170 stars 37 forks source link

Bump ASM to support Java 24 #184

Closed ah-OOG-ah closed 1 month ago

ah-OOG-ah commented 1 month ago

Tested in a modified nightly 559. Unimixins has been bumped, but I'm unsure where in the buildscript Unimixins is pulled in

eigenraven commented 1 month ago

@ah-OOG-ah here: https://github.com/GTNewHorizons/GTNHGradle/blob/master/src/main/java/com/gtnewhorizons/gtnhgradle/UpdateableConstants.java#L20

ah-OOG-ah commented 1 month ago

@ah-OOG-ah here: https://github.com/GTNewHorizons/GTNHGradle/blob/master/src/main/java/com/gtnewhorizons/gtnhgradle/UpdateableConstants.java#L20

Should I push this PR, tag a version, and then bump both Unimixins and 3ify in GTNHG?

mitchej123 commented 1 month ago

@ah-OOG-ah is this ready to go or not? Undraft it if it is.

ah-OOG-ah commented 1 month ago

@ah-OOG-ah is this ready to go or not? Undraft it if it is.

I'm unsure of what order to bump things in. Does it have to go GTNHG gets Unimixins bump -> 3ify gets new GTNHG -> GTNHG gets bumped for 3ify or can I just merge this now and then bump both Unimixins and 3ify in GTNHG at once?

mitchej123 commented 1 month ago

gtnhg is for runClient, it would happen after the rest I believe.