GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

No Black Bighorn Sheep unless you dye them with Ink Sacs you cant really get in Twilight Forest. #23

Closed GregoriusT closed 1 year ago

GregoriusT commented 1 year ago

At this Line it says "50% brown, 50% any other color" https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/entity/passive/EntityTFBighorn.java#L28

But here it says random next int 15 instead of 16, resulting in a boundary Error. https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/entity/passive/EntityTFBighorn.java#L37

This will result in Black Bighorns never existing unless you bring inc sacs from the Overworld, because Squids require a specific Water Height that is not a given in Twilight Forest, except for the TODO in the Urghast Tower claiming there is supposed to be a Squid Tank.

If the comment was also to be believed technically the chance of random to turn out 12 too, would slightly weigh it even more towards brown Bighorns. But I guess that is not really important. ;)

Dream-Master commented 1 year ago

Twilight code is a mystery. @jss2a98aj any idea how to fix that if possible ?

Connor-Colenso commented 1 year ago

We don't tend to look at individual mods issue trackers much, better to put it in the main GTNH one @GregoriusT, but the report is always appreciated.

We could just change it to return any colour with equal weight. I don't see the harm. Brown sheep have always been boring to me. Twilight is supposed to be magical ;)

GregoriusT commented 1 year ago

Lol all that needs be done is change that 15 to a 16 and it would work. It was an off by one Error ofcourse. XD

And I have been told by a Raven to go here instead of the GTNH Issue Tracker, since this is a standalone thing.

I would be fine with an even chance for all colors too, even though it might ruin the stackability of all the wool I get from the brown bighorns. Maybe I should stop judging sheep by the stackability of their wool. XD