GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

Minoshroom Axe, Knightly Axe and Knightly Sword do not do advertised Extra Damage! #30

Closed GregoriusT closed 7 months ago

GregoriusT commented 1 year ago

While searching for how much extra Damage the Axe does when charging I found that the +3.5 Hearts of extra damage are never applied to anything because the following function is never called.

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFMinotaurAxe.java#L68

And instead the private variable is used to calculate Damage

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFMinotaurAxe.java#L117-L119

And yes I tested that in world too. No Extra Damage at all.

Edit: Same applies to Knightly Weapons just that THOSE have their Code for the +1 Heart of Damage commented out entirely.

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFKnightlySword.java#L70-L88 https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFKnightlyAxe.java#L77-L94

Gordon-Frohman commented 7 months ago

Fixed all of this in my PR