search

GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

Fix hardcoded world height. #37

Closed AbdielKavash closed 8 months ago

AbdielKavash commented 8 months ago

Quick fix as I just remembered this:

Replaces all hardcoded values of world height in tree generation with a call to world.getHeight(). In one case the hardcoded value was incorrect (128); this fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/14031.

bombcar commented 8 months ago

What does world.getHeight() return in the nether? did this break breaking bedrock?

AbdielKavash commented 8 months ago

world.getHeight() is the maximum height at which a block can be placed. To the best of my knowledge this is always 256, and I have no idea if making a custom WorldProvider that redefines it would break anything. (It would certainly break anything that implicitly assumes that it is 256.)

I have tested this right now to be 100% sure, and with the change I can grow TF trees above y = 200+ in the Nether.

Some types of trees do displace bedrock when grown. I have not touched this behavior, and it is not isolated to TF trees only.