search

GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

Adds stalactite ore placing override API #41

Open YannickMG opened 7 months ago

YannickMG commented 7 months ago

The intent is to allow the core mod (or any other mod) to specify which ores should be in the stalactites by providing a method to place that stalactite's blocks.

This is an alternative to the method used in #36.

image image

Thanks to Minepolz320 for the original idea.

github-actions[bot] commented 7 months ago

Warning: 2 uncommitted changes https://github.com/GTNewHorizons/twilightforest/pull/42

Gordon-Frohman commented 7 months ago

There's one thing I don't really like about this method: you can't really tweak the rarity of the stalactite you're generating, plus you're not really adding a new stalactite, you're just replacing an existing one. I would rather add an option to add new stalactites, that would've compete for generation with vanilla ones. I guess I'll have to do it in my PR)

Gordon-Frohman commented 7 months ago

You can check my version out in #44

Gordon-Frohman commented 4 months ago

Did you check how it works with GT ores? Because I'm afraid that it may cause issues similar to those I got

YannickMG commented 4 months ago

In draft pending requirements.