GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

Problems with ticon to TF compat #53

Closed chochem closed 7 months ago

chochem commented 7 months ago

Your GTNH Discord Username

chochem

Your Pack Version

GTNH 2.6.0 beta1

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

image

The Reality

Edit: this compat is now disabled in GTNH which resolves some of these issues but not others, which are still relevant for use outside of GTNH:

image (resolved) this is clearly caused by this strange nuggetknightmetel oredict image (unresolved)

Also:

image (unresolved) image (unresolved)

there is also duplicate ticon materials for things like knightmetal. (resolved)

And there are nugget->ingot and ingot->nugget crafting grid recipes. (resolved)

And ticon fluids and recycling where sofar we have been using a gt fluid and gt recycling. (resolved)

Your Proposal

remove the oredict

Final Checklist

chochem commented 7 months ago

looks like its fine in nightly-353. so this was broken between then and the beta.

chochem commented 7 months ago

caused by https://github.com/GTNewHorizons/twilightforest/pull/39

chochem commented 7 months ago

also affects a bunch of other tinker items like wood and stone tool rods, or the stack of paper

chochem commented 7 months ago

there is more here that makes it clear this is not meant for gtnh. like ingot-> nugget and nugget->ingot recipes or alternative recycling recipes. So that is the way I will go for now. I should ping @Gordon-Frohman though, to get some insight or maybe fixes

chochem commented 7 months ago

one other question Dream brought up is if we want to apply the new effects to the exsting tgregworks tools in GTNH. (or something along those lines like replacing them)

Gordon-Frohman commented 7 months ago

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

Dream-Master commented 7 months ago

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

If the Effec is nice i like to add it to GTNH but with right ore dicts. Sure the materials need to be disabled via TGregworks to not have 2 variants in the pack.

chochem commented 7 months ago

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

Hi. Thanks for clarifying that indeed this wasnt meant for GTNH. That makes sense. The oredict issues will still affect you though, yes.

In GTNH these materials already have tinker compact, or more precisely they have gt materials which have tinker compat. This is not quite the same as they of course use gt machines over smeltery and gt fluids instead of added tinker fluids, etc. I prefer that over the swap dream mentions, because it actually works with the gt materials nicely. That also includes the recycling recipes for example. We already got that stuff, just with GT machines and materials.

Of course we also dont want other stuff like nugget to ingot crafting recipe.

But yea the effects might be nice, ideally with the tgregworks materials, we can try to look into that.