GTNewHorizons / twilightforest

Twilight Forest repository
GNU Lesser General Public License v2.1
14 stars 20 forks source link

Adds config for TiC Integration #61

Closed DrParadox7 closed 6 months ago

DrParadox7 commented 7 months ago

Allow disabling of #39 using configs:

   # Enable backport of 1.12.2 TiC integration including materials and modifiers [Default: true].
    B:EnableTiConstructIntegration=true
Dream-Master commented 7 months ago

I have nothing against the cfg option but i want that gtnh has this materials enabled or that the modifyer be in the gt materials

DrParadox7 commented 7 months ago

i want that gtnh has this materials enabled

I'm assuming you want the effects of the TF Integration to match GT5U, correct me if wrong. This might not be wise to do it balance-wise. I just had a look at what GT5U choice of effects and they all are extra modifiers in TiC:

Ironwood GT5U: Fortune I -> [Stacks with Lapis Modifier] TF Integration: Nothing

Steel Leaf GT5U: Fortune II -> [Stacks with Lapis Modifier] TF Integration: regenerate durability, with the speed depending of the amount of steeleafs in your toolbar (TLDR: Mending)

Knight Metal GT5U: Sharpness III -> [Stacks with Quartz Modifier] TF Integration: 10% chance of giving a Resistance effect on hit

If allowed to stack these would be far too OP imho. I can do it in a separate PR but I wouldn't recommend it.

Are you sure @Dream-Master?

Clarified over Discord. To have new TF Integration effects applied to the existing TGregworks tinker tools currently available to GTNH.

DrParadox7 commented 7 months ago

Added configurable Material IDs:

"tinker integration" {
    # Enable backport of 1.12.2 TiC integration including materials and modifiers.
    B:EnableTiConstructIntegration=true

    # Tinker Material ID for FieryMetal.
    I:FieryMetal_ID=42

    # Tinker Material ID for KnightMetal.
    I:KnightMetal_ID=43

    # Tinker Material ID for NagaScale.
    I:NagaScale_ID=44

    # Tinker Material ID for Steeleaf.
    I:Steeleaf_ID=45
}