search

GTNewHorizons / worldedit-gtnh

Other
9 stars 6 forks source link

EntityPlayerMP null exception #6

Closed elak93 closed 5 months ago

elak93 commented 5 months ago

With chatgpt help I believe I have addressed an unchecked cast issue in the onPlayerInteract method by adding a type check to ensure safe casting to EntityPlayerMP, mitigating the risk of ClassCastException. To fix https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/16151

Caedis commented 5 months ago

I can already predict a spotless pr by the bot

Caedis commented 5 months ago

Besides the whitespace changes, it looks good to me

elak93 commented 5 months ago

Hmm I did run spotless prior to upload, is there another step to doing that? And I assume white space changes are from me getting syntax wrong and attempting to fix

Caedis commented 5 months ago

Looks like one of the mavens is down. We can try again in a couple hours

Dream-Master commented 5 months ago

gradle 8.1.1 was outdated we use 8.7

Dream-Master commented 5 months ago

to review this just exlude my addition otherwise its a mess