GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
199 stars 28 forks source link

Fix enemy hitbox priorities #223

Closed Kuma-Boo closed 1 year ago

Kuma-Boo commented 1 year ago

Description of changes

Actual changes:

Some extra things to note:

Issue(s)

Closes #128 Fixes the first reproduction scenario of #118

Kuma-Boo commented 1 year ago

After making some comparisons with the original flash version, The Flash version has an absurdly large hitbox, but seems to only be active for about 12 frames. Redux's spin in comparison has a super long active window of 30 frames.

Not really a big deal as we can always nerf it later and it's pretty unrelated to this pr, but I just thought I should document it.

Koopa1018 commented 1 year ago

Hmm. That duration change is a good thing to note.

Koopa1018 commented 1 year ago

(come to think of it I suppose I was talking about the giant hitbox before, not the timing...that probably caused some confusion 🤦)

Koopa1018 commented 1 year ago

(whoa. just checked the timing out and dang you weren't kidding--that window is BIG.)