GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
195 stars 27 forks source link

Using FLUDD doesn't change the player's animation #228

Open Koopa1018 opened 1 year ago

Koopa1018 commented 1 year ago

Describe the bug The player's animation doesn't change when FLUDD hovering. When starting a hover, the player enters a jump animation if grounded, but otherwise remains in whatever animation was already going. Thus, hovering looks different if started when rising, when falling, or even when double jumping.

In most cases, this behavior doesn't cause problems--no jump animation looks wrong when hovering--but by hovering around the sides of T1R4's rotating blocks, I can get the player hovering in a walking animation. Leaving the animation to luck will let a lot of other wrong animations creep in too, if given the chance.

(Also, some of the jump animations look more or less connected to the hover action than others. IMO the double jump animation looks best, jump B looks worst. That's a subjective matter, though.)

To Reproduce

  1. Use FLUDD while grounded, or during the rising half of a jump. Observe Mario's pose.
  2. Use FLUDD while falling. Observe Mario's pose.
  3. Use FLUDD during the rising half of a double jump. Observe Mario's pose.

Expected behavior Mario's animation logic accounts for hovering in some way. (It'd be cool if there was a specialized animation set for hovering, but hardly required.)

Screenshots Repro cases 1, 2, and 3, in order. Note the well-established water trail. image

System Information

Additional context N/A

Koopa1018 commented 1 year ago

Hmm. Good that I actually got this post made, but dang--self-consistent it ain't.

Not sure this even qualifies as a "bug"--more just a "thing we need to consider at some point."