GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
195 stars 27 forks source link

Pause menu buttons' stars appear wrong #231

Closed Koopa1018 closed 12 months ago

Koopa1018 commented 1 year ago

Describe the bug The buttons at the bottom of the pause menu have little scrolling star patterns on them. Since the 4.1 update, these stars have used the wrong visual behavior.

When things work as intended, the stars are meant to be stationary and somewhat faded. When the buttons are moused over, the stars begin scrolling, and they stop when the mouse leaves the button; when the buttons are pressed down, the stars become darkened with the button, and scroll regardless of where the mouse is.

Since the 4.1 update, the stars have always appeared as though their buttons are pressed, showing their darkened appearance and constantly scrolling.

To Reproduce Visit the pause menu in the 4.1 branch.

Expected behavior The stars respond to the mouse and the button's state as described above.

Screenshots Top: release v0.1.6.alpha. Bottom: 4.1 branch. Motion not pictured. image

System Information

Additional context N/A

Koopa1018 commented 1 year ago

This seems to have somehow fixed itself...can anyone else repro?

Kuma-Boo commented 1 year ago

Can't seem to reproduce this.

Koopa1018 commented 1 year ago

Seems to still happen in the branch fix-incorrect-flud-size, which predates #215. I guess one of us must've fixed this since then and I didn't notice?

Koopa1018 commented 12 months ago

Huh! Looks like I myself did 😅 🤦