search

GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
199 stars 28 forks source link

Fix ground pounding moving platforms #241

Closed Kuma-Boo closed 1 year ago

Kuma-Boo commented 1 year ago

Description of changes

Removes the wind-up from character_sprite.gd (If we really want this effect, it should be implemented by actually moving the character instead of just the sprite, so physics can remain consistent) Fixes the order of processing ground pound inputs. SIRIUS: This makes ground pounds work correctly on moving platforms.

Issue(s)

Closes #179

Koopa1018 commented 1 year ago

This does make sense as a fix, but I added the wind-up because it really does make the pound feel more impactful, and I feel like removing it would hurt the gameplay experience.

You mentioned moving the player instead of the sprite...I've also been thinking that would be a good way to do it. I'll see if I can get that implemented.

jaschutte commented 1 year ago

I agree, moving the player character would probably be the best way to handle this, could you add that functionality into this PR?

Koopa1018 commented 1 year ago

Scratch that. Windup changes have been reverted. Rest of it is ready for review....