GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
195 stars 27 forks source link

Water meter bubbles don't follow meter when resizing #246

Closed Koopa1018 closed 11 months ago

Koopa1018 commented 12 months ago

Describe the bug Resizing the window makes the bubbles in the water meter appear to drift off, as though the source of the bubbles was being moved relative to them. With extreme changes, e.g. entering fullscreen, it appears as though the tank was suddenly emptied of bubbles.

To Reproduce

  1. Get FLUDD.
  2. Drag the right side of the screen to resize the window, at various speeds. Watch the bubbles in the water meter.
  3. Enter and exit fullscreen repeatedly. Watch the bubbles reset each time.

Expected behavior The bubbles move with the water meter when resizing.

Screenshots image that ain't right

System Information

Additional context May be related to #237,

GTcreyon commented 11 months ago

You say "as though the source of the bubbles was being moved relative to them" - I think this is literally the cause of the issue. We're moving the particle emitter since it's part of the scene tree, but we're not moving the particles because they're drawn arbitrarily by the GPU, or something.