GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
193 stars 25 forks source link

Implement SFX banks as a resource rather than a hardcoded dictionary #251

Closed GTcreyon closed 11 months ago

GTcreyon commented 11 months ago

Describe the feature you'd like The SFX_BANK in player.gd is enormous, full of hardcoded inflexible file paths, and makes the rest of the script hard to read. It could easily be replaced with a resource file with dynamic UID (export var) references to solve both of these problems, and make it more designer-friendly.

Do you intend to contribute this yourself? If so, how do you plan on doing it? Probably. It will likely coincide and intersect with #244, so that should be handled with care, although these issues are not mutually dependent.

Koopa1018 commented 11 months ago

Duplicate of #108.