search

GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
193 stars 25 forks source link

Fixed moving platform pushing player if not on platform #273

Closed siddharthroy12 closed 10 months ago

siddharthroy12 commented 10 months ago

Description of changes

Fixed moving platform pushing player even when it's not on the platform.

Issue(s)

Closes #178

siddharthroy12 commented 10 months ago

I like the two Area2D idea. I think that will work for all cases

siddharthroy12 commented 10 months ago

I have implemented this but the lower box is one pixel lower to prevent the edge collsion. image

jaschutte commented 10 months ago

@GTcreyon could you double check, as you requested changes

GTcreyon commented 10 months ago

@GTcreyon could you double check, as you requested changes

I'm not too pressed about it, as long as it works.

jaschutte commented 10 months ago

Yeah but I can't merge it until you approved the changes x3

GTcreyon commented 10 months ago

Oops.

GTcreyon commented 10 months ago

Thank you for following through with the suggestion, by the way. It's always a bit tough converting what seemed to be a trivial PR into something more complex.