GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
193 stars 25 forks source link

Refactor pound spin #275

Closed Koopa1018 closed 8 months ago

Koopa1018 commented 10 months ago

Description of changes

Moves the pound spin animation from player.gd to character_sprite.gd. The effect is purely visual (can't affect FLUDD angle since you can't FLUDD during a pound), so it probably shouldn't be lumped in with the player physics.

Not to be confused with the pound spin rise animation, which does affect player physics. See #247 for that.

Issue(s)

Makes good on a longstanding TODO in the code.

Before merge:

GTcreyon commented 8 months ago

I suspect this will be obsoleted by #244. Should this be closed?

Koopa1018 commented 8 months ago

Hmm, yeah, good call