GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
193 stars 25 forks source link

3.5 keybinds are broken in 4.1 #276

Open Koopa1018 opened 10 months ago

Koopa1018 commented 10 months ago

Describe the bug 4.1 builds do not interpret saved 3.5 keybinds correctly. The default 3.5 arrow key mapping appears as Ctrl+, and does not respond in-game.

The problem also applies in reverse--3.5 builds interpret keybinds from 4.1 as .

To Reproduce

  1. Run release v0.1.6.alpha and reset keybinds to default.
  2. Close 0.1.6.alpha and run master branch. Attempt to control Mario.
  3. Reset keybinds to default. Attempt to control Mario.
  4. Close master branch and run 0.1.6.alpha again. Attempt to control Mario.
  5. Reset keybinds to default. Attempt to control Mario.

Expected behavior 4.1 builds do not produce invalid results when loading 3.5 keybinds. At minimum, invalid keybinds should be reverted to default. Ideally, 3.5 keybinds are automatically upgraded to 4.1-compatible bindings.

(Loading 4.1 keymaps in 3.5 seems unnecessary, but users should probably be informed that "keymaps in the latest version won't load correctly in v0.1.6.alpha or earlier" or something to that effect.)

Screenshots How 3.5 keybinds look in 4.1: image And 4.1 keybinds in 3.1: image

System Information

Additional context N/A