GTcreyon / SM63Redux

Code base for Super Mario 63 Redux
https://sm63redux.com
Mozilla Public License 2.0
193 stars 25 forks source link

Fix odd behaviour when player moves backwards during the uncrouch animation #283

Closed Kawtious closed 9 months ago

Kawtious commented 9 months ago

Description of changes

Make it so that uncrouching (crouch resetting) is counted as a valid case for allowing a turn around while moving. This prevents the odd behaviour of moving backwards while the uncrouch animation is still playing.

Issue(s)

Closes #180

Kawtious commented 9 months ago

How it used to work:

https://github.com/GTcreyon/SM63Redux/assets/75398915/5bc11a2d-c9fc-4ea8-af4b-91325c10003c

How it works now:

https://github.com/GTcreyon/SM63Redux/assets/75398915/88139848-2f86-4b5e-8690-0d4cd4c95a32

Kawtious commented 9 months ago

Also I would like to propose allowing the player to turn around WHILE crouched, as a reply to this comment:

From @WSDguy2014:

It's up to your preference if you want to fix this or not. My opinion is that this bug should be fixed, otherwise as what I said earlier in the additional context that this would lead to some interesting unusual movement tech like this that's been used in future custom courses/levels and newcomer/casual players would not understand how to perform this movement.

Maybe an alternative expected behavior idea for the fix would be: player would still not move during this animation, waiting for the animation to end and then facing & moving the other direction.

This would allow the player to correct the direction in which they are facing while crouched.

https://github.com/GTcreyon/SM63Redux/assets/75398915/72529333-b00e-499a-a07e-e8dcf65e8ae1

However, this seems like a somewhat significant change to gameplay that might not be appropriate for this PR, so I won't include it unless asked. Instead, I'd like to hear opinions about such change, and I'd like to know if this proposal would be more appropriate to have a separate PR from this one.